Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

envision: look ma, it's more missing dependencies! #374404

Conversation

Pandapip1
Copy link
Contributor

internal screaming

I would have thought building the program would have been enough to determine that all dependencies were met. Apparently not.

Once again,

CC @Scrumplex

Ref: #358664 (comment)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Pandapip1 Pandapip1 requested a review from Scrumplex January 16, 2025 23:57
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 17, 2025
@txkyel
Copy link

txkyel commented Jan 17, 2025

Thank you, can confirm that envision now successfully builds and runs wivrn on this branch

@Pandapip1
Copy link
Contributor Author

Given how much of a help you've been highlighting when things have gone wrong, mind if I just add you as a maintainer to the envision package? I'm in the unfortunate position of having to leave my main PC and Quest 3 at home, so there's really only a limited amount of testing I can do.

@txkyel
Copy link

txkyel commented Jan 17, 2025

If being a maintainer simply means just being someone that can be pinged to test if things work then I don't mind.

I'm not too familiar with the underlying implementation of envision or the tools it provides so I'm not sure if I'd be able to help with anything besides testing.

@Scrumplex Scrumplex merged commit 1cbd9e5 into NixOS:master Jan 17, 2025
24 of 27 checks passed
@Pandapip1
Copy link
Contributor Author

If being a maintainer simply means just being someone that can be pinged to test if things work then I don't mind.

Yup, it'll ping you when there's an update that needs to be tested, and it'll also give your review more weight if you say something works.

@Pandapip1 Pandapip1 deleted the how-many-freaking-dependencies-is-wivrn-missing-wth branch January 17, 2025 18:16
dustypomerleau pushed a commit to dustypomerleau/nixpkgs that referenced this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants