Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google-chrome: Fix Qt support #375279

Merged
merged 1 commit into from
Jan 21, 2025
Merged

google-chrome: Fix Qt support #375279

merged 1 commit into from
Jan 21, 2025

Conversation

stereomato
Copy link
Contributor

Basically, up until now Google Chrome simply wasn't capable of using the Qt engine support. Clicking on the "Use Qt" button on Appearance settings would do nothing.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@stereomato
Copy link
Contributor Author

I'm a complete beginner at this, but at least I can attest to the changes working on my machine, related to #228751

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jan 20, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 20, 2025
@nix-owners nix-owners bot requested review from JohnRTitor and jnsgruk January 20, 2025 08:31
@stereomato stereomato force-pushed the google-chrome-qt branch 3 times, most recently from 1c0900c to 1831d19 Compare January 20, 2025 23:54
@stereomato
Copy link
Contributor Author

Alright! With this, it does build and work fine. I don't know why your suggested changes don't work, though. @aucub

@stereomato
Copy link
Contributor Author

Alright, no, finally NOW it works fine.

@stereomato
Copy link
Contributor Author

Now, it does work, but it doesn't seem to export the menus the same way it did before, with the broken makeWrapper results...

@JohnRTitor JohnRTitor requested a review from K900 January 21, 2025 04:17
@stereomato
google-chrome: Fix QT support
ad370bf 
Up until now, the AllowQt feature and the "Use Qt" button on Chrome's settings simply did nothing, now, they work.

Related to: NixOS#228751

Signed-off-by: stereomato <[email protected]>
jnsgruk
jnsgruk approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@jnsgruk jnsgruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and seems to work, thank you!

@jnsgruk jnsgruk added the backport release-24.11 Backport PR automatically label Jan 21, 2025
@jnsgruk jnsgruk merged commit db1a74c into NixOS:master Jan 21, 2025
26 of 28 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 21, 2025

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Jan 21, 2025
Merged
1 task
@stereomato
Copy link
Contributor Author

Nice! There's a problem though, while this does work and enables the QT support on Chrome, I'm still not able to see the menu entries in the KDE global menu. It worked before when I used other settings in the derivation, but the result of the derivation would have ./result/bin/google-chrome-stable be all messed up. Any ideas?

@JohnRTitor
Copy link
Contributor

JohnRTitor commented Jan 21, 2025 •
edited
Loading

Are you using Wayland? If yes, global menus are not supported in Electron/Chromium based apps in Wayland sessions. (Upstream bug: electron/electron#34335)

@stereomato
Copy link
Contributor Author

Ah, indeed, when using the broken derivation, it runs on X11. Thanks.

@stereomato stereomato deleted the google-chrome-qt branch January 21, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K900 K900 K900 left review comments

@jnsgruk jnsgruk jnsgruk approved these changes

@JohnRTitor JohnRTitor Awaiting requested review from JohnRTitor

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12. first-time contribution This PR is the author's first one; please be gentle! backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stereomato @JohnRTitor @K900 @jnsgruk @NixOSInfra