emacs: make cairo optional #375289
Merged
emacs: make cairo optional #375289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nix-owners
bot
requested review from
matthewbauer,
AndersonTorres,
ttuegel,
jian-lin and
adisbladis
jian-lin
reviewed
Jan 21, 2025
kilesduli
force-pushed
the
emacs-xft-switchs
branch
from
33029ec to
d47f0fa
Compare
kilesduli
force-pushed
the
emacs-xft-switchs
branch
from
d47f0fa to
bcba6a4
Compare
jian-lin
reviewed
Jan 21, 2025
kilesduli
force-pushed
the
emacs-xft-switchs
branch
from
bcba6a4 to
2fad85e
Compare
github-actions
bot
added
10.rebuild-darwin: 0
jian-lin
approved these changes
Jan 22, 2025
jian-lin
reviewed
Jan 22, 2025
kilesduli
force-pushed
the
emacs-xft-switchs
branch
from
2fad85e to
7aaac7e
Compare
I noticed that libxft was missing from the buildInputs of make-emacs.nix. After a brief observation, I found that cairo and xft are mutually exclusive options, so I made cairo optional. When `withCairo = false;` will fallback to xft.
kilesduli
force-pushed
the
emacs-xft-switchs
branch
from
7aaac7e to
4fc79e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that libxft was missing from the buildInputs of make-emacs.nix. After a brief observation, I found that cairo and xft are mutually exclusive options, so I made cairo optional. When
withCairo = false;will fallback to xft.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.