libnvidia-container: fix dangling symlinks #375291
Merged
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
10.rebuild-darwin: 0
|
Driveby commenting that this fixes the nvidia breakage in k3s's containerd. |
farcaller
approved these changes
Jan 22, 2025
wegank
added
the
12.approvals: 1
samuela
reviewed
Jan 26, 2025
NixOS@a5fef0d caused some dangling symlinks in the package output by stubbing `ldconfig`. This fixes it by recreating the symlinks after the package is built, keeping the compilation working on `aarch64-linux`. Can be tested via checking the `result/lib` directory before the mentioned commit, after it, and with this fix. Signed-off-by: Moritz Sanft <[email protected]>
msanft
force-pushed
the
msanft/libnvidia-container/symlink-fixes
branch
from
28c845c to
835109e
Compare
samuela
approved these changes
Jan 30, 2025
|
Is extensively tested by us by now, so merging this here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a5fef0d caused some dangling symlinks in the package output by stubbing
ldconfig. This fixes it by recreating the symlinks after the package is built, keeping the compilation working onaarch64-linux.Can be tested via checking the
result/libdirectory before the mentioned commit, after it, and with this fix.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.