Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes https://github.com/NoXF/libwebp-sys/issues/29 #30

Merged
merged 3 commits into from
Sep 2, 2024

Conversation

lilith
Copy link
Contributor

@lilith lilith commented Aug 20, 2024

No description provided.

@NoXF
Copy link
Owner

NoXF commented Aug 26, 2024

it seems not to pass all the tests. can you try to fix them

@lilith
Copy link
Contributor Author

lilith commented Aug 26, 2024

Can you share your test run failures? I don't see any CI executions. This only disables debug info generation, so it would be bizarre for it to change test results.

@lilith
Copy link
Contributor Author

lilith commented Aug 26, 2024

Although, it does set opt-level=2 for the test profile, so it's probably that.. the tests simply haven't been running with optimizations before, and thus haven't been catching release-mode issues. Consider running both cargo test and cargo test --release in CI.

@NoXF
Copy link
Owner

NoXF commented Aug 27, 2024

The failed CI information can be found in the commit of your fork branch. It's not a big problem just a format error and a
wasm target error(maybe introduced by a wasm upgrade).

emcc: error: unsupported target: wasm32-unknown-unknown (emcc only supports wasm64-unknown-emscripten and wasm32-unknown-emscripten)

and I have written a CI fix branch, you can refer to whether it works

@NoXF NoXF merged commit 8e7a124 into NoXF:master Sep 2, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants