Autodetect CPU target features from Cargo #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It‘s a good idea. but it doesn't pass all test cases. I tried to figure out what was wrong but it didn't work. Can you try to fix it? |
|
It’s a weird one – it only fails on beta and not stable or nightly, and I can’t reproduce it locally. My only idea is that some errors occured while globbing that were swallowed up, so I pushed a change to ensure that errors result in panics as usual. It’s also possible something just got corrupted somehow and we just need to re-run. |
|
Damn, I don’t have a clue then. Just to check it’s not a regression, can you try rerunning CI for the latest commit on the master branch? |
|
aha! Well at least it’s not this change… still a mystery though |
|
Indeed the master will also fail, I'll see why later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that users can enable SIMD support using standard Cargo methods, instead of having to know about this crate’s feature flags in particular.