Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils/export: fix GIF export on Windows #220

Merged
merged 1 commit into from
Feb 2, 2024
Merged

utils/export: fix GIF export on Windows #220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions pynopegl-utils/pynopegl_utils/export.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
#

import os
import os.path as op
import platform
import subprocess
import sys
Expand Down Expand Up @@ -99,15 +100,19 @@ class EncodeProfile:
def export_workers(scene_info: ngl.SceneInfo, filename: str, resolution: str, profile_id: str):
profile = ENCODE_PROFILES[profile_id]
if profile.format == "gif":
with tempfile.NamedTemporaryFile(prefix="palette-", suffix=".png") as palette:
# tempfile.NamedTemporaryFile has limitations on Windows, see
# https://docs.python.org/3/library/tempfile.html#tempfile.NamedTemporaryFile
with tempfile.TemporaryDirectory(prefix="Nope_") as td:
palette_name = op.join(td, "palette.png")

# pass 1
extra_enc_args = ["-vf", "palettegen", "-update", "1", "-frames:v", "1", "-c:v", "png", "-f", "image2"]
export = _export_worker(scene_info, palette.name, resolution, extra_enc_args)
export = _export_worker(scene_info, palette_name, resolution, extra_enc_args)
for progress in export:
yield progress / 2

# pass 2
extra_enc_args = ["-i", palette.name, "-lavfi", "paletteuse", "-c:v", profile.encoder, "-f", profile.format]
extra_enc_args = ["-i", palette_name, "-lavfi", "paletteuse", "-c:v", profile.encoder, "-f", profile.format]
export = _export_worker(scene_info, filename, resolution, extra_enc_args)
for progress in export:
yield 50 + progress / 2
Expand Down
Loading