-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nodes: rename Render* to Draw* #239
Conversation
2127388
to
25a8735
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc needs some more adjustments:
doc/usr/expl/media-time-remapping.md:sub-tree (in our case, it will typically be a [Render] using a [Media] node as
doc/usr/expl/media-time-remapping.md:[Render]: /usr/ref/libnopegl.md#render
doc/usr/expl/noise.md:attached to the associated [Render] or [Compute].
doc/usr/expl/noise.md:[Render]: /usr/ref/libnopegl.md#render
doc/usr/expl/scopes.md:can be attached to [Render] vertex or fragment resources, or [Compute]
doc/usr/expl/scopes.md:[Render]: /usr/ref/libnopegl.md#render
doc/usr/expl/shaders.md:When constructing a graphic pipeline (`Render` node), the geometry information
doc/usr/expl/shaders.md:`Render.attributes` or `Render.instance_attributes`. These attributes will be
doc/usr/expl/shaders.md:`Render.vert_resources`. Since this parameter is a dictionary, the user can
doc/usr/expl/shaders.md:`Render.frag_resources`. Since this parameter is a dictionary, the user can
doc/usr/expl/shaders.md:`Render.vert_resources`, `Render.frag_resources` or `Compute.resources` to be
doc/usr/expl/shaders.md:render = Render(geometry, program)
doc/usr/howto/c-api.md:and how a basic `Render` node works. If not, you are encouraged to check out
doc/usr/howto/path.md:Rendering a path with a single cubic curve looks like this:
doc/usr/howto/shapes.md:Rendering a triangle
doc/usr/howto/shapes.md:Rendering a quadrilateral
doc/usr/howto/shapes.md:Rendering a circle with 64 points
doc/usr/howto/shapes.md:Rendering a custom geometry composed of 4 random points
doc/usr/ref/pynopegl.md:`*Dict` | `dict` | `render = Render(geometry, frag_resources={'tex0': t0, 'tex1': t1})`
You might also want to Edit: and a 2nd pass with Edit2: yes I'm an idiot, you need to rename the usage after that as well... |
8ec1c96
to
b8cdd17
Compare
2967e8c
to
9c7d984
Compare
9c7d984
to
41105ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the next
branch in the nope.demos
repository after pushing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most pynopegl-utils/pynopegl_utils/examples
scenes are broken and need adjustments
41105ce
to
7b74b09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, see my comment on the nope.demos
repository though
7b74b09
to
bb24450
Compare
RenderToTexture is not renamed as it is not a drawing node.
bb24450
to
39b1ad1
Compare
RenderToTexture is not renamed as it is not a drawing node.