Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product links do not work on ontology pages due to insecure redirect #2403

Closed
manulera opened this issue Jul 12, 2023 · 7 comments · Fixed by #2411
Closed

Product links do not work on ontology pages due to insecure redirect #2403

manulera opened this issue Jul 12, 2023 · 7 comments · Fixed by #2411
Assignees
Labels
pipeline Issues related to development or revision of global Foundry pipelines website Issues related to the OBO Foundry website

Comments

@manulera
Copy link

Page affected: https://obofoundry.org/ontology/fypo.html (and pressumably others)

When clicking on the "Product" links, they are not opened nor downloaded because insecure redirect. The error from the browser console:

Mixed Content: The site at 'https://obofoundry.org/' was loaded over a secure connection, but the file at 'https://objects.githubusercontent.com/github-production-release-asset-2e65be/38594364/53d30b24-1465-4592-8c5e-b41ada5642f5?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20230712%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20230712T075252Z&X-Amz-Expires=300&X-Amz-Signature=8828ec2159dd7b55ba5a2cb54728ceafa6c1b0d5598bde00cec58493c920272a&X-Amz-SignedHeaders=host&actor_id=22526102&key_id=0&repo_id=38594364&response-content-disposition=attachment%3B%20filename%3Dfypo.obo&response-content-type=application%2Foctet-stream' was redirected through an insecure connection. This file should be served over HTTPS. This download has been blocked. See https://blog.chromium.org/2020/02/protecting-users-from-insecure.html for more details.

Screenshot 2023-07-12 at 08 54 30

@matentzn
Copy link
Contributor

@sierra-moxon, @manulera seems to have read you mind and already made the issue. :)

@erik-whiting, this will probably be switching this line:

https://github.com/OBOFoundry/OBOFoundry.github.io/blob/master/_layouts/ontology_detail.html#L129

To https. Maybe there are some other links on that page that need to be changed as well, and maybe also in the download box on the overview table..

@nlharris nlharris added website Issues related to the OBO Foundry website pipeline Issues related to development or revision of global Foundry pipelines labels Jul 13, 2023
@matentzn
Copy link
Contributor

@erik-whiting would you be able to deal with this, or would you prefer someone else to be assigned?

@cmungall
Copy link
Contributor

broader context: OBOFoundry/purl.obolibrary.org#705

we need to be very careful on the messaging here. It needs to be super-clear on the OBO site

  • what are the PURLs, which should be used as subject of triples (ALWAYS http)
  • what are download URLs, to be clicked on in a browser (ALWAYS https)

We should have the TWG sign off on the PR for this

@erik-whiting
Copy link
Contributor

@erik-whiting would you be able to deal with this, or would you prefer someone else to be assigned?

PR: #2411

@matentzn
Copy link
Contributor

@erik-whiting excellent, thank you.

It is my understanding we have a clear line on this: http for Term identifiers, https for resources/files.. do you have @cmungall any concerns with the PR as Erik made it?

@matentzn
Copy link
Contributor

matentzn commented Aug 8, 2023

I think the fix worked. Correct me if I am wrong :D

@manulera
Copy link
Author

manulera commented Aug 9, 2023

Works for FYPO at least!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pipeline Issues related to development or revision of global Foundry pipelines website Issues related to the OBO Foundry website
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants