Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use https for download links #2411

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Conversation

erik-whiting
Copy link
Contributor

Fixes #2403

@matentzn
Copy link
Contributor

matentzn commented Aug 8, 2023

@balhoff says to risk it and merge it. I am risking it now. If things break we can roll back.

@matentzn matentzn merged commit 427803e into master Aug 8, 2023
@matentzn matentzn deleted the ew/2403-use-https-in-download-links branch August 8, 2023 16:30
@kltm
Copy link
Contributor

kltm commented Aug 8, 2023

I wish I could find the other issue where we had the discussion, but I would note that having a text link that looks like a URL and then having the actual link go elsewhere is a common trigger for "bad actor" systems, which can affect SEO and some browsers (and/or plugins).

@nlharris
Copy link
Contributor

nlharris commented Aug 8, 2023

Is this the other issue you're referring to? #2346

Agree that a URL that links to some other URL looks dodgy; why is that necessary? Why can't they match?

@kltm
Copy link
Contributor

kltm commented Aug 8, 2023

@nlharris Alas, no--I was an active participant and there was more context and conversation about the specific issue of text vs URL (vs IRI).

@matentzn
Copy link
Contributor

matentzn commented Aug 9, 2023

@kltm this is the issue you are thinking: OBOFoundry/purl.obolibrary.org#705

We are not though linking a URL with http to one with https. We are linking an ID string (like mondo) to the HTTPS download link, precisely because otherwise, Chrome blocks the http link we previously had..

@kltm
Copy link
Contributor

kltm commented Aug 9, 2023

@matentzn Alas, not that one--I may be thinking of a slack convo or otherwise. Hm.

Thank you for the clarification--my misunderstanding of "id" in this case. Note withdrawn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Product links do not work on ontology pages due to insecure redirect
4 participants