Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] account_analytic_menu: New module account_analytic_menu #728

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

mpascuall
Copy link

This module adds a new menu item on Invoicing to structure analytic in a more user-friendly way.

New module account_analytic_menu

cc https://github.com/APSL 164801

@miquelalzanillas @lbarry-apsl @BernatObrador @peluko00 @javierobcn @ppyczko please review

Copy link
Contributor

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat and code review

@mpascuall mpascuall force-pushed the 16.0-add-account_analytic_menu branch from 08221f9 to 44ee6ee Compare December 13, 2024 08:11
Copy link

@ppyczko ppyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link

@Daemo00 Daemo00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@@ -0,0 +1 @@
This module adds a menu to structure the analytic in a more user-friendly way.s
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This module adds a menu to structure the analytic in a more user-friendly way.s
This module adds a menu to structure the analytic in a more user-friendly way.

@@ -0,0 +1,5 @@
First make sure your user has the accounting permission.

Then navegate to Invoicing -> Analytic Accounting.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Then navegate to Invoicing -> Analytic Accounting.
Then navigate to Invoicing -> Analytic Accounting.

Comment on lines +12 to +19
<menuitem
id="account.menu_action_analytic_lines_tree"
name="Analytic Items"
action="analytic.account_analytic_line_action_entries"
groups="analytic.group_analytic_accounting"
sequence="35"
parent="account.menu_analytic_accounting"
/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is editing the existing menu https://github.com/odoo/odoo/blob/07e935f73eee5450a150fec74d404cc9b0ee274d/addons/account/views/account_menuitem.xml#L33

<menuitem id="menu_action_analytic_lines_tree" name="Analytic Items" action="analytic.account_analytic_line_action_entries" groups="analytic.group_analytic_accounting" sequence="50"/>

mostly assigning the same values to its fields; could you please just edit the fields that need to be edited? It looks like parent and sequence should be enough.
Otherwise we should keep this menu synced with every change in the linked menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants