[MIG] purchase_analytic: Migration to 17.0 #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-analytic-12.0/account-analytic-12.0-purchase_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-purchase_analytic/
Some of the "tricks" done in this module are no longer needed and can be easily implemented with newest framework features: * No need for an auxiliar `project_id2` field. User can set an analytic account with no lines and it is respected. * Simplify onchange. Now update analytic line on the go (no need to save) which is a better UX because avoid unexpected changes on save. Also re-label the field `project_id` to "Analytic Account" to align with the typical label in newer versions of Odoo. Tha label "Contract / Analytic" was last used in v8 ( https://github.com/odoo/odoo/blob/8.0/addons/sale/sale.py#L217).
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-analytic-15.0/account-analytic-15.0-purchase_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-15-0/account-analytic-15-0-purchase_analytic/
Currently translated at 100.0% (3 of 3 strings) Translation: account-analytic-16.0/account-analytic-16.0-purchase_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-purchase_analytic/hr/
Currently translated at 100.0% (3 of 3 strings) Translation: account-analytic-16.0/account-analytic-16.0-purchase_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-purchase_analytic/es/
Currently translated at 100.0% (3 of 3 strings) Translation: account-analytic-16.0/account-analytic-16.0-purchase_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-purchase_analytic/fr/
Co-authored-by: Alexis de Lattre <[email protected]>
Currently translated at 100.0% (4 of 4 strings) Translation: account-analytic-16.0/account-analytic-16.0-purchase_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-purchase_analytic/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-analytic-16.0/account-analytic-16.0-purchase_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-purchase_analytic/
Currently translated at 100.0% (5 of 5 strings) Translation: account-analytic-16.0/account-analytic-16.0-purchase_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-purchase_analytic/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-analytic-16.0/account-analytic-16.0-purchase_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-purchase_analytic/
Currently translated at 100.0% (5 of 5 strings) Translation: account-analytic-16.0/account-analytic-16.0-purchase_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-purchase_analytic/it/
Currently translated at 100.0% (5 of 5 strings) Translation: account-analytic-16.0/account-analytic-16.0-purchase_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-purchase_analytic/pt_BR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-analytic-16.0/account-analytic-16.0-purchase_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-purchase_analytic/
Currently translated at 100.0% (7 of 7 strings) Translation: account-analytic-16.0/account-analytic-16.0-purchase_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-purchase_analytic/it/
Currently translated at 100.0% (7 of 7 strings) Translation: account-analytic-16.0/account-analytic-16.0-purchase_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-purchase_analytic/pt_BR/
|
Hello @luisg123v @StefanRijnhart Could you please review this PR? It already includes the additional tests to increase the coverage. Best regards. |
desdelinux
approved these changes
Jan 12, 2025
CLaurelB
force-pushed
the
17.0-mig-purchase_analytic-CLaurelB
branch
from
5371f88 to
73c470e
Compare
luisg123v
suggested changes
Jan 16, 2025
purchase_analytic/models/purchase.py
Outdated
| @@ -30,14 +26,17 @@ def _compute_analytic_distribution(self): | |||
| po.analytic_distribution = al | |||
|
|
|||
| def _inverse_analytic_distribution(self): | |||
| """When set analytic_distribution set analytic distribution on all order lines""" | |||
| """When setting analytic_distribution, apply the analytic distribution to all | |||
| order lines.""" | |||
There was a problem hiding this comment.
Nitpick:
Move closing quotes to the next lines, to follow PEP8 recommendations regarding multi-line docstrings
| @@ -1,4 +1,4 @@ | |||
| <?xml version="1.0" encoding="utf-8" ?> | |||
| <?xml version="1.0" ?> | |||
There was a problem hiding this comment.
Why? I'd avoid this, AFAIK it's preferred to provide explicitly the encoding.
| # Test setting analytic distribution with an order line | ||
| po.order_line = self.add_new_order_line() | ||
| po.analytic_distribution = self.analytic_distribution_manual2 | ||
| po._onchange_analytic_distribution() |
There was a problem hiding this comment.
If you need to cover an onchange, it's preferred to use the Form class
There was a problem hiding this comment.
Refactored to use the Form class.
| "product_id": self.product_id.id, | ||
| "product_qty": 1.0, | ||
| "product_uom": self.uom_id.id, | ||
| "price_unit": 121.0, |
There was a problem hiding this comment.
I'd suggest making these params configurable and provide default values, so it may be called without params but also being able to provide some of them.
There was a problem hiding this comment.
As part of the refactoring, the non-required fields were removed, and the product was set as a parameter.
| def test_analytic_distribution(self): | ||
| def add_new_order_line(self): | ||
| return [ | ||
| Command.create( |
There was a problem hiding this comment.
Why don't you pass the order as param?
| ], | ||
| } | ||
| ) | ||
| po = self.env["purchase.order"].new({"partner_id": self.partner_id.id}) |
| analytic_plan = self.env["account.analytic.plan"].create( | ||
| {"name": "Plan Test", "company_id": False} | ||
| ) | ||
| analytic_plan = self.env["account.analytic.plan"].create({"name": "Plan Test"}) |
There was a problem hiding this comment.
Why this? Document it in commit description.
There was a problem hiding this comment.
Documented in the commit.
|
Closing because the original PR is active again. |
Changelog: - Set the `readonly` attribute of the purchase analytic field on the views based on its state, instead of defining it in the model. - Update method docstrings to be more descriptive. - Refactor tests to use `SetUpClass` and remove the unnecessary `_id` when acquiring a record (not just the id). - Remove the unrequired parameters when creating a line. - Add test cases for setting the analytic distribution on a purchase order without lines and unsetting the analytic distribution on a purchase order with lines. - Use `Form` to test the onchange method. - Add the user to the "Analytic Accounting" group in order to visualize analytic distributions in the forms. - Remove the `company_id` field from the creation of `analytic_plan` as the field was moved to the `account.analytic.applicability` model in [1]. [1]: odoo/odoo@dc696c8e Co-authored-by: Wodran Van de Sande <[email protected]>
CLaurelB
force-pushed
the
17.0-mig-purchase_analytic-CLaurelB
branch
from
73c470e to
2081187
Compare
|
This PR has the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersed #707