Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] quality_control_team_oca: Migration to 14.0 #1217

Merged
merged 6 commits into from
Mar 4, 2024
Merged

[14.0][MIG] quality_control_team_oca: Migration to 14.0 #1217

merged 6 commits into from
Mar 4, 2024

Conversation

kaynnan
Copy link

@kaynnan kaynnan commented Feb 28, 2024 •
edited
Loading

cc @marcelsavegnago @WesleyOliveira98 @Alisson-Jns

Changes in v14.0:

  1. Added aria-label, role, and title attributes to the <i> tag. Omitting these attributes resulted in the mentioned warning.
  2. Replaced the deprecated method _company_default_get("qc.team") with self.env.company.

@kaynnan kaynnan marked this pull request as ready for review February 28, 2024 16:59
@kaynnan kaynnan force-pushed the 14.0-mig-quality_control_team_oca branch from 5e79b7d to 06534f4 Compare March 4, 2024 13:45
@kaynnan kaynnan force-pushed the 14.0-mig-quality_control_team_oca branch from 06534f4 to 9b57d5a Compare March 4, 2024 13:46
wsnipez

This comment was marked as duplicate.

Sign in to view

WesleyOliveira98
WesleyOliveira98 approved these changes Mar 4, 2024
View reviewed changes
Copy link

@WesleyOliveira98 WesleyOliveira98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@kaynnan
Copy link
Author

kaynnan commented Mar 4, 2024

ping @OCA/manufacturing-maintainers

@pedrobaeza
Copy link
Member

/ocabot migration quality_control_team_oca
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 14.0 milestone Mar 4, 2024
@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-1217-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Mar 4, 2024
Closed
23 tasks
@OCA-git-bot OCA-git-bot merged commit 370d5a0 into OCA:14.0 Mar 4, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 647a5ec. Thanks a lot for contributing to OCA. ❤️

@kaynnan kaynnan deleted the 14.0-mig-quality_control_team_oca branch March 4, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvalyi rvalyi rvalyi approved these changes

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

@WesleyOliveira98 WesleyOliveira98 WesleyOliveira98 approved these changes

@wsnipez wsnipez wsnipez approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
7 participants
@kaynnan @OCA-git-bot @pedrobaeza @rvalyi @marcelsavegnago @WesleyOliveira98 @wsnipez