Skip to content

Commit

Permalink
[IMP] sale_product_variant_attribute_tax: pre-commit auto fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
HeliconiaSolutions committed Jan 17, 2025
1 parent 692af52 commit 39245c5
Show file tree
Hide file tree
Showing 13 changed files with 72 additions and 52 deletions.
50 changes: 28 additions & 22 deletions sale_product_variant_attribute_tax/README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -17,20 +17,20 @@ Put attribute taxes on sales orders
:target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
:alt: License: AGPL-3
.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fproduct--variant-lightgray.png?logo=github
:target: https://github.com/OCA/product-variant/tree/16.0/sale_product_variant_attribute_tax
:target: https://github.com/OCA/product-variant/tree/17.0/sale_product_variant_attribute_tax
:alt: OCA/product-variant
.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
:target: https://translation.odoo-community.org/projects/product-variant-16-0/product-variant-16-0-sale_product_variant_attribute_tax
:target: https://translation.odoo-community.org/projects/product-variant-17-0/product-variant-17-0-sale_product_variant_attribute_tax
:alt: Translate me on Weblate
.. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
:target: https://runboat.odoo-community.org/builds?repo=OCA/product-variant&target_branch=16.0
:target: https://runboat.odoo-community.org/builds?repo=OCA/product-variant&target_branch=17.0
:alt: Try me on Runboat

|badge1| |badge2| |badge3| |badge4| |badge5|

This module uses *product_variant_attribute_tax* for adding the taxes set
on product attribute values when adding a product in sales orders that contains
this attribute value.
This module uses *product_variant_attribute_tax* for adding the taxes
set on product attribute values when adding a product in sales orders
that contains this attribute value.

**Table of contents**

Expand All @@ -40,57 +40,63 @@ this attribute value.
Use Cases / Context
===================

As the product taxes are defined at product template level, you can't have some variants with an specific tax.
As the product taxes are defined at product template level, you can't
have some variants with an specific tax.

These modules family covers the gap, adding the taxes at attribute level. This design decision has been taken for allowing to define the tax only once, as other options like having taxes at product variant level will force you to define the specific taxes for each of the variants that are affected.
These modules family covers the gap, adding the taxes at attribute
level. This design decision has been taken for allowing to define the
tax only once, as other options like having taxes at product variant
level will force you to define the specific taxes for each of the
variants that are affected.

Usage
=====

To use this module, you need to:

#. Go to *Sales > Orders > Quotations*, create a new quotation or edit
1. Go to *Sales > Orders > Quotations*, create a new quotation or edit
an existing one.
#. Create a new order line or edit an existing one.
#. when editing the table "Product attributes", the taxes of that sales
2. Create a new order line or edit an existing one.
3. when editing the table "Product attributes", the taxes of that sales
line will be completed with the default taxes of the attribute value
specified.

Known issues / Roadmap
======================

- This module requires `sale_variant_configurator` as a way to avoid 2 glue modules, but it may be independent.
- This module requires sale_variant_configurator as a way to avoid 2
glue modules, but it may be independent.

Bug Tracker
===========

Bugs are tracked on `GitHub Issues <https://github.com/OCA/product-variant/issues>`_.
In case of trouble, please check there if your issue has already been reported.
If you spotted it first, help us to smash it by providing a detailed and welcomed
`feedback <https://github.com/OCA/product-variant/issues/new?body=module:%20sale_product_variant_attribute_tax%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
`feedback <https://github.com/OCA/product-variant/issues/new?body=module:%20sale_product_variant_attribute_tax%0Aversion:%2017.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.

Do not contact contributors directly about support or help with technical issues.

Credits
=======

Authors
~~~~~~~
-------

* Tecnativa

Contributors
~~~~~~~~~~~~
------------

* `Tecnativa <https://www.tecnativa.com>`_:
- `Tecnativa <https://www.tecnativa.com>`__:

* Vicent Cubells
* Pedro M. Baeza
* Ernesto Tejeda
* Carolina Fernandez
- Vicent Cubells
- Pedro M. Baeza
- Ernesto Tejeda
- Carolina Fernandez

Maintainers
~~~~~~~~~~~
-----------

This module is maintained by the OCA.

Expand All @@ -102,6 +108,6 @@ OCA, or the Odoo Community Association, is a nonprofit organization whose
mission is to support the collaborative development of Odoo features and
promote its widespread use.

This module is part of the `OCA/product-variant <https://github.com/OCA/product-variant/tree/16.0/sale_product_variant_attribute_tax>`_ project on GitHub.
This module is part of the `OCA/product-variant <https://github.com/OCA/product-variant/tree/17.0/sale_product_variant_attribute_tax>`_ project on GitHub.

You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.
3 changes: 3 additions & 0 deletions sale_product_variant_attribute_tax/pyproject.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[build-system]
requires = ["whool"]
build-backend = "whool.buildapi"
8 changes: 8 additions & 0 deletions sale_product_variant_attribute_tax/readme/CONTEXT.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
As the product taxes are defined at product template level, you can't
have some variants with an specific tax.

These modules family covers the gap, adding the taxes at attribute
level. This design decision has been taken for allowing to define the
tax only once, as other options like having taxes at product variant
level will force you to define the specific taxes for each of the
variants that are affected.
3 changes: 0 additions & 3 deletions sale_product_variant_attribute_tax/readme/CONTEXT.rst

This file was deleted.

5 changes: 5 additions & 0 deletions sale_product_variant_attribute_tax/readme/CONTRIBUTORS.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
- [Tecnativa](https://www.tecnativa.com):
- Vicent Cubells
- Pedro M. Baeza
- Ernesto Tejeda
- Carolina Fernandez
6 changes: 0 additions & 6 deletions sale_product_variant_attribute_tax/readme/CONTRIBUTORS.rst

This file was deleted.

3 changes: 3 additions & 0 deletions sale_product_variant_attribute_tax/readme/DESCRIPTION.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
This module uses *product_variant_attribute_tax* for adding the taxes
set on product attribute values when adding a product in sales orders
that contains this attribute value.
3 changes: 0 additions & 3 deletions sale_product_variant_attribute_tax/readme/DESCRIPTION.rst

This file was deleted.

2 changes: 2 additions & 0 deletions sale_product_variant_attribute_tax/readme/ROADMAP.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- This module requires sale_variant_configurator as a way to avoid 2
glue modules, but it may be independent.
1 change: 0 additions & 1 deletion sale_product_variant_attribute_tax/readme/ROADMAP.rst

This file was deleted.

8 changes: 8 additions & 0 deletions sale_product_variant_attribute_tax/readme/USAGE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
To use this module, you need to:

1. Go to *Sales \> Orders \> Quotations*, create a new quotation or
edit an existing one.
2. Create a new order line or edit an existing one.
3. when editing the table "Product attributes", the taxes of that sales
line will be completed with the default taxes of the attribute value
specified.
8 changes: 0 additions & 8 deletions sale_product_variant_attribute_tax/readme/USAGE.rst

This file was deleted.

24 changes: 15 additions & 9 deletions sale_product_variant_attribute_tax/static/description/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -369,10 +369,10 @@ <h1 class="title">Put attribute taxes on sales orders</h1>
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!! source digest: sha256:9afce924b2b6f83d04c9b06c9127b5876656fbc7171f1a9c0e828388eb114948
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Production/Stable" src="https://img.shields.io/badge/maturity-Production%2FStable-green.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/product-variant/tree/16.0/sale_product_variant_attribute_tax"><img alt="OCA/product-variant" src="https://img.shields.io/badge/github-OCA%2Fproduct--variant-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/product-variant-16-0/product-variant-16-0-sale_product_variant_attribute_tax"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/product-variant&amp;target_branch=16.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
<p>This module uses <em>product_variant_attribute_tax</em> for adding the taxes set
on product attribute values when adding a product in sales orders that contains
this attribute value.</p>
<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Production/Stable" src="https://img.shields.io/badge/maturity-Production%2FStable-green.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/product-variant/tree/17.0/sale_product_variant_attribute_tax"><img alt="OCA/product-variant" src="https://img.shields.io/badge/github-OCA%2Fproduct--variant-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/product-variant-17-0/product-variant-17-0-sale_product_variant_attribute_tax"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/product-variant&amp;target_branch=17.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
<p>This module uses <em>product_variant_attribute_tax</em> for adding the taxes
set on product attribute values when adding a product in sales orders
that contains this attribute value.</p>
<p><strong>Table of contents</strong></p>
<div class="contents local topic" id="contents">
<ul class="simple">
Expand All @@ -390,8 +390,13 @@ <h1 class="title">Put attribute taxes on sales orders</h1>
</div>
<div class="section" id="use-cases-context">
<h1><a class="toc-backref" href="#toc-entry-1">Use Cases / Context</a></h1>
<p>As the product taxes are defined at product template level, you can’t have some variants with an specific tax.</p>
<p>These modules family covers the gap, adding the taxes at attribute level. This design decision has been taken for allowing to define the tax only once, as other options like having taxes at product variant level will force you to define the specific taxes for each of the variants that are affected.</p>
<p>As the product taxes are defined at product template level, you can’t
have some variants with an specific tax.</p>
<p>These modules family covers the gap, adding the taxes at attribute
level. This design decision has been taken for allowing to define the
tax only once, as other options like having taxes at product variant
level will force you to define the specific taxes for each of the
variants that are affected.</p>
</div>
<div class="section" id="usage">
<h1><a class="toc-backref" href="#toc-entry-2">Usage</a></h1>
Expand All @@ -408,15 +413,16 @@ <h1><a class="toc-backref" href="#toc-entry-2">Usage</a></h1>
<div class="section" id="known-issues-roadmap">
<h1><a class="toc-backref" href="#toc-entry-3">Known issues / Roadmap</a></h1>
<ul class="simple">
<li>This module requires <cite>sale_variant_configurator</cite> as a way to avoid 2 glue modules, but it may be independent.</li>
<li>This module requires sale_variant_configurator as a way to avoid 2
glue modules, but it may be independent.</li>
</ul>
</div>
<div class="section" id="bug-tracker">
<h1><a class="toc-backref" href="#toc-entry-4">Bug Tracker</a></h1>
<p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/product-variant/issues">GitHub Issues</a>.
In case of trouble, please check there if your issue has already been reported.
If you spotted it first, help us to smash it by providing a detailed and welcomed
<a class="reference external" href="https://github.com/OCA/product-variant/issues/new?body=module:%20sale_product_variant_attribute_tax%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
<a class="reference external" href="https://github.com/OCA/product-variant/issues/new?body=module:%20sale_product_variant_attribute_tax%0Aversion:%2017.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
<p>Do not contact contributors directly about support or help with technical issues.</p>
</div>
<div class="section" id="credits">
Expand Down Expand Up @@ -448,7 +454,7 @@ <h2><a class="toc-backref" href="#toc-entry-8">Maintainers</a></h2>
<p>OCA, or the Odoo Community Association, is a nonprofit organization whose
mission is to support the collaborative development of Odoo features and
promote its widespread use.</p>
<p>This module is part of the <a class="reference external" href="https://github.com/OCA/product-variant/tree/16.0/sale_product_variant_attribute_tax">OCA/product-variant</a> project on GitHub.</p>
<p>This module is part of the <a class="reference external" href="https://github.com/OCA/product-variant/tree/17.0/sale_product_variant_attribute_tax">OCA/product-variant</a> project on GitHub.</p>
<p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
</div>
</div>
Expand Down

0 comments on commit 39245c5

Please sign in to comment.