Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] upgrade_analysis: forward ports #3143

Merged
merged 3 commits into from
Jan 2, 2025
Merged

[16.0][FIX] upgrade_analysis: forward ports #3143

merged 3 commits into from
Jan 2, 2025
+42 −10

Conversation

MiquelRForgeFlow
Copy link
Contributor

@OCA-git-bot
Copy link
Contributor

Hi @StefanRijnhart, @legalsylvain,
some modules you are maintaining are being modified, check this out!

@MiquelRForgeFlow
Copy link
Contributor Author

Error in CI unrelated (it's due to sentry module).

@hbrunn
Copy link
Member

hbrunn commented Dec 12, 2024

it's not sentry, it's auditlog, fixed in #3146

@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 16.0-fix-upgrade_analysis-minor-things branch from 49d5597 to e04584d Compare December 12, 2024 17:28
@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 16.0-fix-upgrade_analysis-minor-things branch from e04584d to 5e43fce Compare December 31, 2024 17:20
StefanRijnhart
StefanRijnhart approved these changes Dec 31, 2024
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer the 3rd commit to feature the module name as well, but that's something I missed in the original PR so I can't complain really.

@pedrobaeza pedrobaeza added this to the 16.0 milestone Jan 2, 2025
pedrobaeza
pedrobaeza approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-3143-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 01e1161 into OCA:16.0 Jan 2, 2025
7 of 9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 85ccb74. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@MiquelRForgeFlow @OCA-git-bot @hbrunn @StefanRijnhart @pedrobaeza @jcdrubay