-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] base_model_restrict_update: Migration to 16.0 #3150
Open
nobuQuartile
wants to merge
15
commits into
OCA:16.0
Choose a base branch
from
qrtl:16.0-mig-2-base_model_restrict_update
base: 16.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[16.0][MIG] base_model_restrict_update: Migration to 16.0 #3150
nobuQuartile
wants to merge
15
commits into
OCA:16.0
from
qrtl:16.0-mig-2-base_model_restrict_update
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, button presentation of 'Grant Update Permit' and 'Readonly' were broken in the user form with the deprecation of boolean_button widget. In this commit, we switch to use boolean_toggle for these buttons, with some other style adjustments on the buttons.
Currently translated at 100.0% (13 of 13 strings) Translation: server-tools-15.0/server-tools-15.0-base_model_restrict_update Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-base_model_restrict_update/es_AR/
Previously, the exemption for the model update restriction was given by setting unrestrict_model_update to the relevant users. However, this design had the limitation of not being able to control the permitted users per model. This commit addresses this limitation by adding the update_allowed_group_ids field to ir.model, removing the unrestrict_model_update field from res.users. This commit also contains the following changes: - Make the logic of _check_is_readonly_user() more complete - Refactor tests to make them more comprehensive
This one supersedes #3134. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@qrtl QT4777
For a future pull request, I plan to modify the inheritance from check() so that it instead derives from _get_allowed_models(). This method was introduced in version 16.0.