[16.0][FIX]mail_activity_done: Fix counters and activity_state search #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In odoo 16 the systray_get_activities function uses the ORM, there is no need to override it.
jesusVMayor
force-pushed
the
16.0_fix_activity_done
branch
2 times, most recently
from
ea4838f to
df64eed
Compare
|
Fixed tests. |
hbrunn
requested changes
Nov 21, 2024
jesusVMayor
force-pushed
the
16.0_fix_activity_done
branch
from
df64eed to
9ab7f24
Compare
hbrunn
approved these changes
Nov 22, 2024
|
I have detected a new bug, the _read_progress_bar inherit was not properly working and the count of activities in the kanban view was wrong. We should modify the subquery where clause |
jesusVMayor
force-pushed
the
16.0_fix_activity_done
branch
from
1f68c55 to
1f6bc04
Compare
|
Seems a problem with the tests because the function executes the query directly. Testing in shell, if i make the commit after the _action_done, the result is 0. It also happens in the test_activity_state_search. I changed the tests to move the second activity to demo file, assigned to another partner, and created already done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes 2 changes:
and mail_activity.done=Falseto WHERE clause in the query to allow properly search by this field.Fixes: #1327 CC: @gurneyalex @navarrorico