Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] mail_autosubscribe_partner_parent: New module mail_autosubscribe_partner_parent #1525

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

mpascuall
Copy link

This module extends mail_autosubscribe functionality to add the partner parent in copy of their child partner documents.

cc https://github.com/APSL 165068
@miquelalzanillas @lbarry-apsl @javierobcn @peluko00 @BernatObrador @ppyczko please review

@mpascuall mpascuall force-pushed the 16.0-add-mail_autosubscribe_partner_parent branch 2 times, most recently from 6c231de to 6fa4e5c Compare December 20, 2024 12:23
@mpascuall mpascuall force-pushed the 16.0-add-mail_autosubscribe_partner_parent branch 3 times, most recently from a30877d to 1f08c05 Compare January 8, 2025 12:19
@mpascuall mpascuall force-pushed the 16.0-add-mail_autosubscribe_partner_parent branch from 1f08c05 to 7771738 Compare January 8, 2025 12:23
@mpascuall
Copy link
Author

Hi @pedrobaeza, sorry for pinging you out directly. The tests for the mail_autosubscribe module are failing because in this module we add the parent partner, and the tests do not take this into account. What would be the best way to solve this? Could we create an IMP in mail_autosubscribe with a boolean to mark whether to also add the parent partner in CC? Looking forward to your response, thank you very much!

@pedrobaeza pedrobaeza added this to the 16.0 milestone Jan 16, 2025
@pedrobaeza
Copy link
Member

What I'm seeing is that mail_composer_cc_bcc has a signature change upstream and there's a mechanism for failing if that happens. Can you rebase to see if this has changed meanwhile?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants