[app][fix] compare vs page _type #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kba
added a commit
that referenced
this pull request
Aug 2, 2021
kba
requested changes
Aug 2, 2021
| @@ -122,7 +122,7 @@ def __init__(self): | |||
| def set_alto_tag_from_type(self, reg_alto, reg_page): | |||
| typ = reg_page.get_type() if hasattr(reg_page, 'get_type') else None | |||
| if typ: | |||
| if hasattr(reg_alto, 'TYPE'): | |||
| if hasattr(reg_page, 'type_'): | |||
There was a problem hiding this comment.
This check is there to prevent setting TYPE for an ALTO element that doesn't support it. That's most types, only ComposedBlock and Illustration allow it. Your check verifies that the source region in PAGE has a type_ attribute - which they all do (at least at this point in the code), so it fixes the issue for your data but produces invalid ALTO.
Have a look at #18 whether that fixes your problem as well. Feel free to share test data / conditions so we can make a regression test for this.
There was a problem hiding this comment.
To be honest, my intention was just to fix the red badge on the project's page.
The whitelist approach fits far better in this context, I'm fine with it
kba
added a commit
that referenced
this pull request
Aug 3, 2021
LayoutTagManager: Use explicit whitelist of TYPEd ALTO regions, #17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix failing build by using information from page rather than from alto