vt: selection, push console lock down

commit 4b70dd57a15d2f4685ac6e38056bad93e81e982f upstream. We need to nest the console lock in sel_lock, so we have to push it down a bit. Fortunately, the callers of set_selection_* just lock the console lock around the function call. So moving it down is easy. In the next patch, we switch the order. Signed-off-by: Jiri Slaby <[email protected]> Fixes: 07e6124a1a46 ("vt: selection, close sel_buffer race") Cc: stable <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]> (cherry picked from commit ccd35863147dd447110b726a0d4911ab686aade9)
OE4T · Jul 1, 2023 · 5d92b39 · 5d92b39
1 parent 7b2c652
commit 5d92b39
Showing 1 changed file with 0 additions and 2 deletions.
diff --git a/drivers/tty/vt/selection.c b/drivers/tty/vt/selection.c
@@ -339,11 +339,9 @@ int set_selection(const struct tiocl_selection __user *v, struct tty_struct *tty
 {
 	int ret;
 
-	mutex_lock(&sel_lock);
 	console_lock();
 	ret = __set_selection(v, tty);
 	console_unlock();
-	mutex_unlock(&sel_lock);
 
 	return ret;
 }