Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Error in DICOM JSON generation - Using multiple character sets is not supported: ISO_IR 192,ISO 2022 IR 100 #4695

Open
BrunoSkezi opened this issue Jan 16, 2025 · 2 comments
Open

[Bug] Error in DICOM JSON generation - Using multiple character sets is not supported: ISO_IR 192,ISO 2022 IR 100 #4695

BrunoSkezi opened this issue Jan 16, 2025 · 2 comments

Comments

@BrunoSkezi
Copy link

Describe the Bug

Hello,

I am using the DICOM JSON generation solution (https://docs.ohif.org/configuration/datasources/dicom-json/) to make the Viewer work with my S3.
For some DICOM files, when I run the generation script, I encounter an encoding error that prevents the JSON file from being generated :

Error: Using multiple character sets is not supported: ISO_IR 192,ISO 2022 IR 100
    at Function._read (/dicom-json-generator/node_modules/dcmjs/build/dcmjs.js:10074:24)
    at Function.readFile (/dicom-json-generator/node_modules/dcmjs/build/dcmjs.js:10149:35)
    at convertDICOMToJSON (/dicom-json-generator/dicom-json-generator.js:42:51)

Thank you for your help.

Steps to Reproduce

Not possible unless I share one of the files with you, but it's a medical file, so I can't share it.

The current behavior

All in "Describe the Bug" part

The expected behavior

I need to have my JSON DICOM file.

OS

Ubuntu 22

Node version

21.4.0

Browser

Brave
@BrunoSkezi BrunoSkezi added the Awaiting Reproduction Can we reproduce the reported bug? label Jan 16, 2025
@sedghi
Copy link
Member

sedghi commented Jan 16, 2025

Let's see if AI can fix this haha

@sedghi sedghi removed the Awaiting Reproduction Can we reproduce the reported bug? label Jan 16, 2025
devin-ai-integration bot added a commit that referenced this issue Jan 16, 2025
@devin-ai-integration @sedghi
fix: handle multiple character sets gracefully in dicom-json-generator
bc021fd 
- Add ignoreErrors option to DicomMessage.readFile to handle multiple character sets
- Script will now continue processing with first character set when multiple are present
- Addresses issue #4695

Co-Authored-By: Alireza Sedghi <[email protected]>
@devin-ai-integration devin-ai-integration bot mentioned this issue Jan 16, 2025
Closed
@sedghi
Copy link
Member

sedghi commented Jan 16, 2025

It failed miserably

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sedghi @BrunoSkezi