feat: properly handle multiple charsets following DICOM standard #4698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
- Add ignoreErrors option to DicomMessage.readFile to handle multiple character sets - Script will now continue processing with first character set when multiple are present - Addresses issue #4695 Co-Authored-By: Alireza Sedghi <[email protected]>
Co-Authored-By: Alireza Sedghi <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Viewers
|
||||||||||||||||||||||||||||
| Project |
Viewers
|
| Branch Review |
devin/1737054386-fix-multiple-charsets
|
| Run status |
|
| Run duration | 02m 10s |
| Commit |
|
| Committer | Devin AI |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
44
|
| View all changes introduced in this branch ↗︎ | |
|
Not a good solution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix multiple character sets handling in dicom-json-generator
Description
This PR fixes issue #4695 by implementing proper character set handling in dicom-json-generator.js according to the DICOM standard. When multiple character sets are present in a DICOM file, the script now properly detects and handles them following ISO/IEC 2022 Code Extension techniques.
Changes
Implementation Details
Testing
Note: Build and unit tests pass successfully. Awaiting test data with multiple character sets (ISO_IR 192 and ISO 2022 IR 100) for full verification.
Link to Devin run: https://app.devin.ai/sessions/92befc3d9ab945eea8cf5f8d30359353