Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: group measurements by study and other values #4686

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wayfarer3130
Copy link
Contributor

Context

The goal if this feature is to make the measurents panel configurable in terms of how it gets grouped.
To demonstrate this, a custom measurements tab will be created for the basic-test mode which groups first by study instance UID and secondly by 4 sub groups:

  1. Measurements that do not contain site tag
  2. Additional findings
  3. Measurements which contain site tag
  4. Non-saveable measurements

The measurements which contain site tag will only show the top level label name, so will customize the appearance.

Save menu on this custom measurements panel that save everything saveable here.

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 3644587
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/678683c6c42d06000895bc66
😎 Deploy Preview https://deploy-preview-4686--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 3644587
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/678683c646a4f90008a408c9
😎 Deploy Preview https://deploy-preview-4686--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants