feat(panels): responsive thumbnails based on panel size #4709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i library. Added a dependency to react-resizable-panels. The resizing dependency and logic is contained in the ViewerLayout component. Added the isExpanded prop to SidePanel so that expanded/collapsed is no longer tied to the activeTabIndex prop. Refactored SidePanel so that the border sizing info are props and thus the resizable panels can calculate their sizes accordingly. The side panel width sizes were already props. Removed the open and close transition (animation) for the side panels. Added options to make either, both or neither side panels resizable. The tricky part was handling window resizes and converting between pixels and percentages. Fixed the triggers for opening the side panels dynamically.
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
❌ Deploy Preview for ohif-dev failed. Why did it fail? →
|
Viewers
|
||||||||||||||||||||||||||||||||||
| Project |
Viewers
|
| Branch Review |
feat/panel-responsive-layout
|
| Run status |
|
| Run duration | 02m 12s |
| Commit |
|
| Committer | Ibrahim |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
43
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/integration/measurement-tracking/OHIFMeasurementPanel.spec.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| OHIF Measurement Panel > checks if Measurements right panel can be hidden/displayed |
Test Replay
Screenshots
Video
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Building on top of @jbocce Joe's PR to make thumbnails respond to panel resizing
Demos
Thumbnail Items only
CleanShot.2025-01-17.at.20.20.45.mp4
List Items only
CleanShot.2025-01-17.at.20.19.47.mp4
Mix of thumbnail items and list items
CleanShot.2025-01-17.at.20.21.52.mp4