Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move dynamic import module fix to handler #3810

Merged

Conversation

benfurber
Copy link
Member

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Bugfix (fixes an issue)

What is the current behavior?

I got the similar error locally after #3808.

Screenshot 2024-07-31 at 12 54 13

I've moved the handler to a place slightly higher in the flow (and with other error handles)

@benfurber benfurber requested a review from a team as a code owner July 31, 2024 12:16
Copy link

cypress bot commented Jul 31, 2024



Test summary

66 0 1 0Flakiness 0


Run details

Project onearmy-community-platform
Status Passed
Commit fb85af1
Started Jul 31, 2024 12:24 PM
Ended Jul 31, 2024 12:29 PM
Duration 04:24 💡
OS Linux Ubuntu -
Browser Chrome 127

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@mariojsnunes mariojsnunes self-requested a review July 31, 2024 13:48
@benfurber benfurber merged commit af3f0a5 into ONEARMY:master Jul 31, 2024
19 checks passed
@onearmy-bot
Copy link
Collaborator

🎉 This PR is included in version 1.206.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@benfurber benfurber deleted the fix/move-dynamic-import-failure-fix branch October 22, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants