qemu_v8: fix "SCMI_DTB" with QEMU v9.2.0 #807
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etienne-lms
reviewed
Jan 24, 2025
only the $(SCMI_DTB): has not been updated jens updated the run: and jerome fixed the check: |
jforissier
reviewed
Jan 24, 2025
There was a problem hiding this comment.
Please reword:
but it does not take into account 'make $(SCMI_DTB)'.
and use instead:
but it does not update the $(SCMI_DTB) recipe.
With that:
Reviewed-by: Jerome Forissier <[email protected]>
Commit 1977c37 ("qemu_v8: support new path to QEMU v9.2.0") allows QEMU v9.2.0 to be used for 'make run[-only]', but it does not update the $(SCMI_DTB) recipe. Signed-off-by: Vincent Guittot <[email protected]> Reviewed-by: Jerome Forissier <[email protected]>
vingu-linaro
force-pushed
the
qemu_v8_scmi_dtb
branch
from
98b9e6a to
1f57b9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 1977c37 ("qemu_v8: support new path to QEMU v9.2.0") allows QEMU v9.2.0 to be used for 'make run[-only]', but it does not take into account 'make $(SCMI_DTB)'.