Skip to content

Commit

Permalink
Merge pull request cibernox#1640 from mkszepp/remove-package-ember-hr…
Browse files Browse the repository at this point in the history
…ef-to

DOCS: Remove `ember-href-to` package & replace usings
  • Loading branch information
mkszepp authored Jan 12, 2024
2 parents 1d22bee + dd678c1 commit 1f142a1
Show file tree
Hide file tree
Showing 8 changed files with 28 additions and 60 deletions.
2 changes: 1 addition & 1 deletion docs/app/templates/public-pages.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
<div class="main-footer-content">
Deployed with love by <a href="http://github.com/cibernox">Miguel Camba</a>
<div class="contribute-call-to-action">
Enjoy the addon? <a href={{href-to "public-pages.support-the-project"}}>Support it!</a>
Enjoy the addon? <LinkTo @route="public-pages.support-the-project">Support it!</LinkTo>
</div>
</div>
</footer>
Expand Down
2 changes: 1 addition & 1 deletion docs/app/templates/public-pages/docs/index.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -39,5 +39,5 @@
<p>Let's see how.</p>

<div class="doc-page-nav">
<a href={{href-to "public-pages.docs.installation"}} class="doc-page-nav-link-next">Installation &gt;</a>
<LinkTo @route="public-pages.docs.installation" class="doc-page-nav-link-next">Installation &gt;</LinkTo>
</div>
8 changes: 4 additions & 4 deletions docs/app/templates/public-pages/docs/styles.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@

<p>
This approach is powerful enough to build entire themes on top of it and to prove it Ember Power Select
ships with a <a href={{href-to "public-pages.cookbook.bootstrap-theme"}}>Bootstrap theme</a> and a
<a href={{href-to "public-pages.cookbook.material-theme"}}>Material theme</a> out of the box that
ships with a <LinkTo @route="public-pages.cookbook.bootstrap-theme">Bootstrap theme</LinkTo> and a
<LinkTo @route="public-pages.cookbook.material-theme">Material theme</LinkTo> out of the box that
can also be used in projects not using any preprocessor.
</p>

Expand All @@ -38,6 +38,6 @@
</p>

<div class="doc-page-nav">
<a href={{href-to "public-pages.docs.the-search"}} class="doc-page-nav-link-prev">&lt; The search</a>
<a href={{href-to "public-pages.docs.custom-search-action"}} class="doc-page-nav-link-next">Advanced customization &gt;</a>
<LinkTo @route="public-pages.docs.the-search" class="doc-page-nav-link-prev">&lt; The search</LinkTo>
<LinkTo @route="public-pages.docs.custom-search-action" class="doc-page-nav-link-next">Advanced customization &gt;</LinkTo>
</div>
6 changes: 3 additions & 3 deletions docs/app/templates/public-pages/docs/the-list.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@
<h3>Disabling specific options or groups</h3>

<p>
In <a href={{href-to "public-pages.docs.the-trigger"}}>The trigger</a> we saw how to disable the entire component,
In <LinkTo @route="public-pages.docs.the-trigger" class="doc-page-nav-link-prev">The trigger</LinkTo> we saw how to disable the entire component,
but you can also disable specific options. Options that have a <code>disabled</code> property set to true
will automatically be considered disabled and styled as such.
</p>
Expand Down Expand Up @@ -164,6 +164,6 @@ This is particularly useful if you want to add some kind of link or button insid
</CodeExample>

<div class="doc-page-nav">
<a href={{href-to "public-pages.docs.the-trigger"}} class="doc-page-nav-link-prev">&lt; The trigger</a>
<a href={{href-to "public-pages.docs.the-search"}} class="doc-page-nav-link-next">The search &gt;</a>
<LinkTo @route="public-pages.docs.the-trigger" class="doc-page-nav-link-prev">&lt; The trigger</LinkTo>
<LinkTo @route="public-pages.docs.the-search" class="doc-page-nav-link-next">The search &gt;</LinkTo>
</div>
4 changes: 2 additions & 2 deletions docs/app/templates/public-pages/docs/the-search.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,6 @@ In the default multiple select without searchbox you can use the <code>placehold
to have put text in the trigger.

<div class="doc-page-nav">
<a href={{href-to "public-pages.docs.the-list"}} class="doc-page-nav-link-prev">&lt; The list</a>
<a href={{href-to "public-pages.docs.styles"}} class="doc-page-nav-link-next">Styles &gt;</a>
<LinkTo @route="public-pages.docs.the-list" class="doc-page-nav-link-prev">&lt; The list</LinkTo>
<LinkTo @route="public-pages.docs.styles" class="doc-page-nav-link-next">Styles &gt;</LinkTo>
</div>
8 changes: 4 additions & 4 deletions docs/app/templates/public-pages/docs/the-trigger.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<h3>The selected option</h3>

<p>
As we saw in the <a href={{href-to "public-pages.docs.how-to-use-it"}}>How to use it</a> section, Ember Power Select
As we saw in the <LinkTo @route="public-pages.docs.how-to-use-it">How to use it</LinkTo> section, Ember Power Select
will reuse the same block used for each element of the list for the content of the trigger, both
in normal and multiple mode, but this is something you can also customize if you need to.
</p>
Expand Down Expand Up @@ -51,7 +51,7 @@
</CodeExample>

Take into account that in the multiple selects with search enabled, the trigger contains a searchbox
and you should use the <code>searchPlaceholder</code> option instead. Check <a href={{href-to "public-pages.docs.the-search"}}>The search</a>
and you should use the <code>searchPlaceholder</code> option instead. Check <LinkTo @route="public-pages.docs.the-search">The search</LinkTo>
section for more info.

<h3>Set a complex placeholder</h3>
Expand Down Expand Up @@ -88,6 +88,6 @@ section for more info.
</p>

<div class="doc-page-nav">
<a href={{href-to "public-pages.docs.multiple-selection"}} class="doc-page-nav-link-prev">&lt; Multiple selection</a>
<a href={{href-to "public-pages.docs.the-list"}} class="doc-page-nav-link-next">The list &gt;</a>
<LinkTo @route="public-pages.docs.multiple-selection" class="doc-page-nav-link-prev">&lt; Multiple selection</LinkTo>
<LinkTo @route="public-pages.docs.the-list" class="doc-page-nav-link-next">The list &gt;</LinkTo>
</div>
1 change: 0 additions & 1 deletion docs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@
"ember-cli-mirage": "^3.0.2",
"ember-cli-sass": "^11.0.1",
"ember-code-snippet": "git+https://[email protected]/ef4/ember-code-snippet.git#d054b697098ad52481c94a952ccf8d89ba1f25fe",
"ember-href-to": "^5.0.0",
"ember-prism": "^0.13.0",
"memory-scroll": "^1.0.2",
"miragejs": "^0.1.48",
Expand Down
57 changes: 13 additions & 44 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 1f142a1

Please sign in to comment.