Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Challenge: Add misconfiguration for mounting in secret in during build #1790

Merged
merged 22 commits into from
Feb 4, 2025

Conversation

Shubham-Patel07
Copy link
Contributor

@Shubham-Patel07 Shubham-Patel07 commented Dec 13, 2024

What kind of changes does this PR include?

  • Fixes or refactors
  • A new challenge
  • Additional documentation
  • Something else

To Do

Relations

Closes #812

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • I added UI tests to ensure my UI changes work (when change in the overall UI, not needed if just adding a challenge)
  • The PR passes pre-commit hooks and automated tests

@Shubham-Patel07
Copy link
Contributor Author

Shubham-Patel07 commented Dec 13, 2024

Hi @commjoen sir,
the env_var is not properly been injected to container for some reason
Please check the Dockerfile
https://github.com/OWASP/wrongsecrets/pull/1790/files#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557R20-R26

@commjoen
Copy link
Collaborator

Files have been shared over Slack ^^, looking forward to the challenge implementation good sir!

@OWASP OWASP deleted a comment from Shubham-Patel07 Feb 3, 2025
Copy link
Collaborator

@commjoen commjoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR @Shubham-Patel07 ! Just a final lap to go! Can you please have a look at the suggested changes, then we can merge this baby :)

pom.xml Outdated Show resolved Hide resolved
js/index.js Outdated Show resolved Hide resolved
src/main/resources/explanations/challenge52.adoc Outdated Show resolved Hide resolved
@commjoen commjoen changed the title Add misconfiguration for mounting in secret in during build Challenge: Add misconfiguration for mounting in secret in during build Feb 4, 2025
@commjoen commjoen merged commit e568b1f into OWASP:master Feb 4, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants