Fix a pydantic crash while enrolling #4
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my setup, OctoPrint 1.11.0.dev287 (latest maintanance branch), Windows and Python 3.12.7, OctoPrint-MfaTotp crashes when clicking the Enroll button, with the following stacktrace:
I believe the error is due to the
MfaTotpUserSettings.last_used
field, which is declared asstr
but initialized toNone
.This PR changes the field declaration to
str|None
. I'm not sure if this is the best change based on the context of the code, but at least it fixes the crash.