Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add xmpp plugin #1264

Merged
merged 7 commits into from
Dec 27, 2023
Merged

Add xmpp plugin #1264

merged 7 commits into from
Dec 27, 2023

Conversation

tobser
Copy link
Contributor

@tobser tobser commented Dec 27, 2023

Adds a plugin to send print progress notifications via xmpp

jneilliii
jneilliii requested changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@jneilliii jneilliii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In your plugin, your software update hook should return a dictionary named after your plugin_identifier.

https://github.com/tobser/octoprint-xmpp-plugin/blob/75dc6406075b77326e56cb97801815c24c075198/octoprint_xmpp_plugin/__init__.py#L207C17-L207C33

change that to

xmpp_plugin=dict(

@tobser tobser requested a review from jneilliii December 27, 2023 21:33
@jneilliii jneilliii merged commit bbe9934 into OctoPrint:gh-pages Dec 27, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneilliii jneilliii jneilliii approved these changes

Assignees
No one assigned
Labels
needs review
Projects
OctoPrint Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobser @jneilliii