Add SkipTo plugin #1317
Add SkipTo plugin #1317
Conversation
|
@awe-source I see only two issues with your plugin that needs to be addressed before release. First your software update hook needs to return the exact same name as your plugin_identifier here: https://github.com/awe-source/OctoPrint-SkipTo/blob/master/octoprint_skipto/__init__.py#L76. skipTo should be SkipTo. Once that change is made on your repo, then you'll need to create a release and tag that matches the version number configured in setup.py (0.1.0) here: https://github.com/awe-source/OctoPrint-SkipTo/releases. Once those two things are addressed comment back here and let me know and I can move forward with the process. |
|
Have, hopefully, made the correct changes |
|
It looks like the software update hook may still be off. Should be like this: def get_update_information(self):
# Define the configuration for your plugin to use with the Software Update
# Plugin here. See https://docs.octoprint.org/en/master/bundledplugins/softwareupdate.html
# for details.
return {
"SkipTo": {
"displayName": "SkipTo",
"displayVersion": self._plugin_version,
# version check: github repository
"type": "github_release",
"user": "awe-source",
"repo": "OctoPrint-SkipTo",
"current": self._plugin_version,
# update method: pip
"pip": "https://github.com/awe-source/OctoPrint-skipTo/archive/{target_version}.zip",
}
} |
|
Fixed? |
|
Yes, that looks good, thanks. |
|
Um do I need to recreate the release? |
|
Can I ask… am I supposed to put things into the release manually?
Eg I don’t fully understand how the whole ecosystem works but a lot of
plugins have 0 active instances” but perhaps this is because a lot of op
are blocked or offline.
But also the “master.zip” is (I assume) the current live/latest version not
a specific version… but I don’t know GH that well either…
Anyway just curious and trying to
Aa. Do the right thing by the ecosystem
And
B. Trying to judge the usefulness/point of this plugin
So far all I have is a bit of offline feedback and GitHub issues
…On Wed, 28 Aug 2024 at 11:21 PM, jneilliii ***@***.***> wrote:
Merged #1317
<#1317> into
gh-pages.
—
Reply to this email directly, view it on GitHub
<#1317 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJCOJ33U2XU25K3SDJLFJZLZTXFHNAVCNFSM6AAAAABNGHNZJ2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGA2DMNJUG4ZTQMQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
|
No stats sometimes means there's a mismatch in plugin ids. Your plugin ID should be the same as the name of the .md file in your registration, and in the metadata at the top of this file. If you're seeing comments/issues, then I'd expect to also see some numbers here. If your software update hook is configured correctly, you should just need to create a release and then it will be picked up by OctoPrint. Installing from the plugin repository (new installs) using the ...master.zip URL will give you whatever is currently on that branch. I'd advise to develop on a separate branch, and then when you're ready to release you merge to master, and then create a release so existing installs can also update. (Note I've not actually checked if your update hook is correct, but this would have been done as part of the review which I trust 😉) |
|
Yeah, looks like the plugin ids are consistent throughout. Pretty sure we went through all that in the initial review, and what I'm seeing on your plugin's repo for releases appears to match up correctly with what's in setup.py. The only issue I'm currently seeing on the plugin listing is a missing image, because of capitalization related issues, skipto.png instead of SkipTo.png. I'll correct that here in a minute. I do not understand why the github and anonymous usage stats aren't populating, but I suspect it's something related to capitalization as well. @foosel any ideas on that? |
|
Does it have anything to do with no stats on any releases “there are no
resources associated with this release “ when I goto stats in GitHub, but
if I goto the releases as another user would see it there is a zip and read
me with each one…?!?
I don’t know GitHub that well so not sure if I’ve configured something wrong
…On Tue, 10 Sep 2024 at 10:00 AM, jneilliii ***@***.***> wrote:
Yeah, looks like the plugin ids are consistent throughout. Pretty sure we
went through all that in the initial review, and what I'm seeing on your
plugin's repo for releases appears to match up correctly with what's in
setup.py. The only issue I'm currently seeing on the plugin listing is a
missing image, because of capitalization related issues, skipto.png instead
of SkipTo.png. I'll correct that here in a minute. I do not understand why
the github and anonymous usage stats aren't populating, but I suspect it's
something related to capitalization as well. @foosel
<https://github.com/foosel> any ideas on that?
—
Reply to this email directly, view it on GitHub
<#1317 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJCOJ33CQPBCIPHJWHZMNHDZVYZCBAVCNFSM6AAAAABNGHNZJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZZGM2TINRYHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I don't think it's that because I don't do anything special outside of taking a release like you've done. |
|
It's nothing you did wrong, there still was a bug in data enrichment here on the plugin repo that I had to touch when this whole stats manipulation happened. I introduced a new |
|
287 instances already, not bad @awe-source |
|
s/years/instances/g ;) |
|
oops...edited. |
|
lol
Cool thanks for the info and fix (and laugh)!
…On Fri, 13 Sep 2024 at 1:59 AM, jneilliii ***@***.***> wrote:
oops...edited.
—
Reply to this email directly, view it on GitHub
<#1317 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJCOJ36Q765PT6IJJCPE2PTZWG26LAVCNFSM6AAAAABNGHNZJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBWGY3TOOJYG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Plugin to start printing at a specified layer.