Add new Plugin - PSU Control IKEA Dirigera #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
another plugin was merged dated 10-7, this update is necessary for notices once plugin is reviewed and approved/merged.
kantlivelong
requested changes
Oct 8, 2024
There was a problem hiding this comment.
This PR looks good but few things on the repo:
-
https://github.com/Mesterkaa/OctoPrint-PSU_Control_IKEA_Dirigera/blob/main/octoprint_psucontrol_ikea_dirigera/__init__.py#L296 - You'll want to update this dict key to match the plugin ID. (Pretty much just lowercase)
-
Drop the
vin your version tag and release.
Perfect. The dict key in get_update_information has been changed: "PSU_Control_IKEA_Dirigera" -> "psucontrol_ikea_dirigera" |
kantlivelong
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added page for a new plugin.
PSU Control - IKEA Dirigera
A sub-plugin for PSU Control
Added .md file and image assets
Plugin:
https://github.com/Mesterkaa/OctoPrint-PSU_Control_IKEA_Dirigera