Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dragging.log #58

Merged
merged 4 commits into from
Apr 26, 2024
Merged

Dragging.log #58

merged 4 commits into from
Apr 26, 2024

Conversation

aiksiongkoh
Copy link
Collaborator

No description provided.

PaddleStroke
PaddleStroke approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@PaddleStroke PaddleStroke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of .mov and .asmt files and debug logs, I'm not sure these files belong in the solver repository. 'SphericalHindeDebug2.asmt' for example sounds like development leftover.

@PaddleStroke
Copy link
Contributor

You have removed some cpp/h files. Are those files not necessary to the solver?

If they are old files or unecessary files, you need to remove them from the cmakeFiles.txt. Else it will not build. See the CI failure report :

Cannot find source file:
OndselSolver/MBDynAxialRotationJoint.cpp

@PaddleStroke PaddleStroke merged commit 2d71435 into main Apr 26, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaddleStroke PaddleStroke PaddleStroke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aiksiongkoh @PaddleStroke