Fix various compiler warnings #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would recommend to use the above settings in the CI. @sliptonic, agreed? If so, @adrianinsaval, could you update the CI? |
|
@chennes, please note that I used even stricter warnings (as errors) than you did, and FreeCAD currently compiles on main with these flags. |
|
I now notice that there is another PR with the same name. This is a coincidence and feel free to rename the PR. |
PaddleStroke
approved these changes
Jul 5, 2024
| #include "EndFramec.h" | ||
|
|
||
| using namespace MbD; | ||
|
|
||
| ConstraintIJ::ConstraintIJ(EndFrmsptr frmi, EndFrmsptr frmj) : frmI(frmi), frmJ(frmj), Constraint() | ||
| ConstraintIJ::ConstraintIJ(EndFrmsptr frmi, EndFrmsptr frmj) : frmI(std::move(frmi)), frmJ(std::move(frmj)) |
There was a problem hiding this comment.
This change I do not know if it can break something.
|
I will merge it and test it to make sure it is OK. If it is OK then I'll PR to upstream. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a range of compiler warnings.
OndselSolver is compiled within FreeCAD with the following settings:
cmake \ -DCMAKE_C_COMPILER=clang \ -DCMAKE_CXX_COMPILER=clang++ \ -DCMAKE_CXX_FLAGS="-Werror=absolute-value -Werror=reorder-ctor -Werror=sign-compare -Werror=overloaded-virtual -Werror=c++11-compat-deprecated-writable-strings -Werror=uninitialized -Werror=unused-parameter -Werror=unused-variable -Werror=nonnull -Werror=overlength-strings -Werror=strncat-size -Werror=strncat-size -Wno-deprecated-declarations" \ etc.