-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct compilation warnings for 'int' casts with correct types #75
Correct compilation warnings for 'int' casts with correct types #75
Conversation
Windows build failed. @huguesdpdn-aerospace please check. Thanks. |
88e07d0
to
7087d59
Compare
Indeed Windows do not recognise |
@huguesdpdn-aerospace Please see build failures due to typo. Thanks. |
@huguesdpdn-aerospace Please remove the extra || in line below |
7087d59
to
ae21e2b
Compare
Hello @aiksiongkoh , sorry I was in vacation. In addition, it was a stupid and easy typo to fix, sorry :/ Can you please approve the test workflow ? Thank you |
ae21e2b
to
f6d0aad
Compare
Hi @aiksiongkoh , thanks for the workflow approval. Unfortunately, couldn't test under Windows and it seems that the macro A copy of the declared data can be found here: Windows 10 SDK - baseTsd.h Need a new approval to re-execute the compilation tests |
Fix a potential error on some specific architectures (aka devices with
sizeof(int)
different ofsizeof(ssize_t)
) where asize_t
orssize_t
are not actually a realint
. When dealing (subtracting or adding values) withsize_t
with negative value,int
you should not be use but rather its dedicated opposite version, aka the signed one:ssize_t
Also, when dealing with
tellg
, actually it returns astreampos
(see C++ Reference | std::streampos ) which should not be incremented or decremented with any integer. Instead, a dedicated method should be called by usingstd::streamoff
for that in the class (see C++ Reference | std::streamoff )