Fix compilation under gcc7.5 #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
StefanBruens
reviewed
Oct 7, 2024
Comment on lines
+362
to
+365
| // https://stackoverflow.com/a/45867491 | ||
| #if __GNUC__ >= 8 |
There was a problem hiding this comment.
Still won't compile due to #include <filesystem> on line 65.
huguesdpdn-aerospace
force-pushed
the
fix_compilation_under_gcc7.5
branch
from
31a1359 to
444c219
Compare
|
@aiksiongkoh or other moderator: can you please re-run this PR workflow to test it ? Thank you and sorry for the delay |
|
@aiksiongkoh are you ok to merge this? |
aiksiongkoh
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
this PR is aim to solve FreeCAD/FreeCAD#16181 which, when compiling with an old and fresh Ubuntu 20.04 that still use GCC version <= 7.5 , a debug output is not correctly processed neither compiled.
For more info, checkout this StackOverflow post: Why does GCC not seem to have the filesystem standard library?
This PR is only impacting GCC compiler version < 8 - In that case, the debug message/output won't be displayed (well, I think nobody cares anyway since currently Ubuntu has GCC version 9 installed. So, in case a developer use a very old version of GCC and if the message is not displayed ... I don't think it is not gonna be a big issue. And in case of debug with GCC version< 8 , I guess Ondsel developers know how to add a
#include <iostream>and astd::cout << ... << std::endl;)