add depth check to oneNoteItemUtils

[JaneHazen]

Add two methods to check depth of notebooks and sections in oneNoteItemUtils

[jogonzal]

nit- notebook isn't two words, therefore noteBook -> notebook

[jogonzal]

Should this be private?

[jogonzal]

Where is this being used?

[jogonzal]

I think you meant parent.sectiongroups here. Also, I suggest using
for(const sectionGroup of parent.sectionGroups){
...
instead of a for with indexes

[JaneHazen]

I think the sectionGroups thing is actually to measure the sections here- it looks weird but changing these around breaks it. I'm mostly copying this code over from the utils in the OneNoteAPI repo we were using before

[jogonzal]

The code says:

---

if (parent.sectionGroups) {
for (let i = 0; i < parent.sections.length; i++) {
maxDepth = Math.max(this.getDepthOfParent(parent.sectionGroups[i]), maxDepth);
}
}

Let's suppose this parent has 1 section groups and 10 sections. It goes inside the if, loops from 0 to 9, and tries to access parent.sectionGroups[i]; It will throw when i=1 because the parent only has 1 section group.

[jogonzal]

Does this mean there's a bug in the OneNoteApi repo we should fix?

[jogonzal]

It'd be good to unit test this method

[jogonzal]

You have a number of entities here that your test use throughout several tests here. I'll simplify a bit:

const notebook1: Notebook = {
... sections: [] ...
}
it('test1', () => {
        notebook1.push(section1);
		const depthOfNotebooks = OneNoteItemUtils.getDepthOfNotebooks([notebook1]);
		expect(depthOfNotebooks).toEqual(2);
	});
it('test2', () => {
        const depthOfNotebooks = OneNoteItemUtils.getDepthOfNotebooks([notebook1]);
		expect(depthOfNotebooks).toEqual(1);
	});

If both tests run in the same persisted browser instance, then the order in which the tests run affects whether they pass or not, because they both use notebook1. A better way to build this could be:

function createNewNotebook(){
  return new {
    ... sections: [] ...
  }
}
it('test1', () => {
        var notebookMock = createNotebookMock();
        notebook1.push(section1);
		const depthOfNotebooks = OneNoteItemUtils.getDepthOfNotebooks([notebookMock]);
		expect(depthOfNotebooks).toEqual(2);
	});
it('test2', () => {
        const depthOfNotebooks = OneNoteItemUtils.getDepthOfNotebooks([createNotebookMock()]);
		expect(depthOfNotebooks).toEqual(1);
	});

[jogonzal]

You can also have a parameter to specify the notebook name (if you wish to) in createNewNotebook().

[jogonzal]

Approving with a suggestion on how to structure tests

[mttwc]

This PR doesn't have any changes. Was it already merged into master via another branch?