Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align Storage account parameters with Ontotext / Azure recommendations #97

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

templier2
Copy link

@templier2 templier2 commented Nov 27, 2024

Description

I disable two default settings (https only and minimal TLS). Worth to say that a setting for https was renamed in newer version of Azure TF provider. Also, I enable usage of SAS keys because it is the only way of recovering from cloud backups as stated here:
https://graphdb.ontotext.com/documentation/10.8/backup-and-restore.html

Related Issues

N/A

Changes

  • removing two settings that have the same default value;
  • change third to allow recover from cloud backups.

Screenshots (if applicable)

Checklist

  • I have tested these changes thoroughly.
  • My code follows the project's coding style.
  • I have added appropriate comments to my code, especially in complex areas.
  • All new and existing tests passed locally.

Remove from a storage account:
- disabling SAS;
- setting minimal TLS to 1.2 (it is default).
Remove enable_https_traffic_only because it is default too (also it was changed in newer versions of AzureRM).
@simonzhekoff simonzhekoff requested review from mihailradkov and cloudvlad and removed request for mihailradkov December 3, 2024 12:47
@simonzhekoff simonzhekoff requested review from viktor-ribchev and removed request for cloudvlad December 17, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant