-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mogpr timestep option #104
Conversation
In the mogpr function, there is an issue when leaving "prediction_period" as default (None): the "output_time_dimension" is not getting defined in that case. Other than that, the function seems to work fine, I ran mogpr with different prediction periods. |
@GriffinBabe Is this based on the code review or did you encounter this during execution? It works for me in both cases. If you ran into the issue, could you please provide a minimal example where I could test this? |
I see now I had unpushed commits... |
Yes it works now, for me you can merge :) |
Changes:
Closes #96
(cc. @GriffinBabe I tried this out myself and it works, but it wouldn't hurt if you also give it a try)