Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mogpr timestep option #104

Merged
merged 9 commits into from
Oct 23, 2023
Merged

Add mogpr timestep option #104

merged 9 commits into from
Oct 23, 2023

Conversation

mlubej
Copy link
Collaborator

@mlubej mlubej commented Oct 10, 2023

Changes:

  • added the option for a custom timestep (provided as '5D' or '1M' etc.
  • fixed a bug where the provided limited set of variables was not used to limit the data

Closes #96

(cc. @GriffinBabe I tried this out myself and it works, but it wouldn't hurt if you also give it a try)

@mlubej mlubej requested a review from jdries October 10, 2023 11:48
@mlubej mlubej self-assigned this Oct 10, 2023
@GriffinBabe
Copy link
Collaborator

In the mogpr function, there is an issue when leaving "prediction_period" as default (None): the "output_time_dimension" is not getting defined in that case. Other than that, the function seems to work fine, I ran mogpr with different prediction periods.

@mlubej
Copy link
Collaborator Author

mlubej commented Oct 20, 2023

In the mogpr function, there is an issue when leaving "prediction_period" as default (None): the "output_time_dimension" is not getting defined in that case. Other than that, the function seems to work fine, I ran mogpr with different prediction periods.

@GriffinBabe Is this based on the code review or did you encounter this during execution? It works for me in both cases.

If you ran into the issue, could you please provide a minimal example where I could test this?

@mlubej
Copy link
Collaborator Author

mlubej commented Oct 23, 2023

If you ran into the issue, could you please provide a minimal example where I could test this?

I see now I had unpushed commits...

@GriffinBabe
Copy link
Collaborator

Yes it works now, for me you can merge :)

@mlubej mlubej merged commit 7233f41 into main Oct 23, 2023
@JanssenBrm JanssenBrm deleted the add-mogpr-timestep-option branch December 14, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the time steps size configurable in the mogpr method
2 participants