Enhance run graph locally #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on. Don't open debug ports. Lighter Dockerfile.
…enhance_run_graph_locally
soxofaan
reviewed
Oct 4, 2024
soxofaan
reviewed
Oct 4, 2024
soxofaan
reviewed
Oct 4, 2024
soxofaan
reviewed
Oct 4, 2024
docker/local_batch_job/Dockerfile
Outdated
| @@ -10,6 +10,7 @@ USER root | |||
| ENV JAVA_HOME=/usr/lib/jvm/jre | |||
There was a problem hiding this comment.
Why are all these env vars necessary, isn't that all set up already in the base image?
There was a problem hiding this comment.
JAVA_HOME seems to be. I took this snippet from another docker script, but it might be unneeded there too.
Removed it here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.