Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This could be considered as a breaking change
I've noticed that
Polygon
was imported twice:geojson_pydantic
shapely.geometry
Because the one from
shapely
was imported later, it was the one used in theGeoJson
type:openeo-pg-parser-networkx/openeo_pg_parser_networkx/pg_schema.py
Line 349 in 9f72a9d
resulting in the type being an Union of pydantic model and Shapely object
I personally think that using shapely only for the
polygon
object is kinda overkill, but if users really need it, it might better be in aBoundingBox.to_shapely()
method