New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue633 threaded download #708

Open

HansVRP wants to merge 3 commits into master from issue633_threaded_download

+21 −5

Contributor

HansVRP commented Jan 15, 2025 •

edited

Loading

Somewhat of a preemptive PR.

I tried to thread of the downloading in a similar style as the threaded MPJM.

I'd also would hope to get some input on needed unit tests. My current ideas are:

to see if the thread is properly closed
to see what happens when the download is interrupted
to verify that multiple threads have been created.

HansVRP added 2 commits

January 14, 2025 16:54


          threading of download

f4c5dad


          refactoring

789b83c

HansVRP requested a review from soxofaan

January 15, 2025 19:45


          refactoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet