Reword intro paragraph #74

strycore · 2025-01-11T20:51:33Z

The rest is my editor autoformatting the markdown

R1kaB3rN · 2025-01-13T18:23:32Z

README.md


 6\. Optionally include a note:

-* For example Genshin Impact has two standalone versions. One from Hoyo, one from PlayPC. Leave a note stating which one it is.
+-   For example Genshin Impact has two standalone versions. One from Hoyo, one from PlayPC. Leave a note stating which one it is.


For example, Genshin Impact has two standalone versions, namely one from Hoyo and one from PlayPC. Leave a note stating which one it is.

R1kaB3rN · 2025-01-13T18:23:39Z

README.md

 5\. Optionally include a commonly used acronym for the game:

-* For example "WoW" is an acronym for World of Warcraft (or also World of Warships)
+-   For example "WoW" is an acronym for World of Warcraft (or also World of Warships)


For example "WoW" is an acronym for World of Warcraft (or also World of Warships)

R1kaB3rN · 2025-01-13T18:23:49Z

README.md

@@ -170,15 +171,14 @@ Red Dead Redemption 2   egs      Heather
 Red Dead Redemption 2   none     none                                  umu-1174180                            standalone
 ```

-* The same applies here. Each different non-steam version protonfix -should- be a symlink to the steam version protonfix UNLESS it requires different fixes.
+-   The same applies here. Each different non-steam version protonfix -should- be a symlink to the steam version protonfix UNLESS it requires different fixes.


The same applies here. Each different non-Steam version protonfix should be a symlink to the Steam version protonfix unless it requires different fixes.

Also, symlink isn't a word, though most people know what it means. Maybe prefer symbolic link?

The same applies here. Each different non-Steam version protonfix should be a symbolic link to the Steam version protonfix unless it requires different fixes.

R1kaB3rN · 2025-01-13T18:24:02Z

README.md

@@ -159,7 +160,7 @@ Genshin Impact          egs      41869934302e4b8cafac2d3c0e7c293d
 Genshin Impact          none     none                                  umu-genshin                            standalone
 ```

-* The protonfix for umu-7d690c122fde4c60bed85405f343ad10 should be a symlink to the protonfix for umu-genshin if they require the same fixes. They -can- be independent -IF- they require different fixes or if it's a new single title and no fix exists
+-   The protonfix for umu-7d690c122fde4c60bed85405f343ad10 should be a symlink to the protonfix for umu-genshin if they require the same fixes. They -can- be independent -IF- they require different fixes or if it's a new single title and no fix exists


The protonfix for umu-7d690c122fde4c60bed85405f343ad10 should be a symlink to the protonfix for umu-genshin if they require the same fixes. They can be independent if they require different fixes or if it's a new single title and no fix exists

Maybe change symlink to symbolic link. See below.

R1kaB3rN · 2025-01-13T18:26:37Z

README.md

@@ -149,7 +150,7 @@ What store does the game come from? GOG? Epic (egs)? Battlenet? Amazon?
             ret.add("gamedrive")
 ```

-* You can have duplicate lines for the same game, the UMU_ID for the game may be different for different store fronts. The only time the umu-id will be the same is if a Steam version exists.
+-   You can have duplicate lines for the same game, the UMU_ID for the game may be different for different store fronts. The only time the umu-id will be the same is if a Steam version exists.


First sentence is confusing. We can remove the comma and use where. Also, we can use storefronts

You can have duplicate records for the same game where the UMU_ID for the game may be different for different storefronts. The only time the umu ID will be the same is if a Steam version exists.

may be different across storefronts:

You can have duplicate records for the same game where the UMU_ID for the game may be different across storefronts. The only time the umu ID will be the same is if a Steam version exists.

R1kaB3rN · 2025-01-13T18:27:33Z

README.md

    `umu-genshinimpact`

-* For games not on steam the second part of the ID should have at least one letter but preferably be a phrase thats easily understandable simply so that it's not parsed as a steam id. We perform a check on the second part of the UMU ID to determine if it's numeric or not. If it is, that part is sent as the steam ID to proton. Protonfixes prioritizes UMU_ID envvar, but proton itself uses SteamAppId for some game specific fixes directly. So, if say the game 'As Dusk falls' has both protonfixes and a proton official specific fix. It's UMU ID would be umu-1341820 which gets passed to protonfixes, while the second part of that -- 1341820 gets parsed and passed as the SteamAppId/appid, this way it allows both Valve's fixes in their proton script (and their wine code) to work as well as our protonfixes.
+-   For games not on steam the second part of the ID should have at least one letter but preferably be a phrase thats easily understandable simply so that it's not parsed as a steam id. We perform a check on the second part of the UMU ID to determine if it's numeric or not. If it is, that part is sent as the steam ID to proton. Protonfixes prioritizes UMU_ID envvar, but proton itself uses SteamAppId for some game specific fixes directly. So, if say the game 'As Dusk falls' has both protonfixes and a proton official specific fix. It's UMU ID would be umu-1341820 which gets passed to protonfixes, while the second part of that -- 1341820 gets parsed and passed as the SteamAppId/appid, this way it allows both Valve's fixes in their proton script (and their wine code) to work as well as our protonfixes.


For games not on Steam the second part of the ID should have at least one letter, but preferably be a phrase that's easily understandable simply so that it's not parsed as a Steam ID. We perform a check on the second part of the umu ID to determine if it's numeric or not. If it is, that part is sent as the Steam ID to Proton. Protonfixes prioritizes the UMU_ID environment variable, but Proton itself uses SteamAppId for some game-specific fixes directly. So, if say the game As Dusk Falls has both protonfixes and an official Proton-specific fix. It's umu ID would be umu-1341820, which gets passed to protonfixes, while the second part of that (1341820) gets parsed and passed as the app ID (SteamAppId). This way, it allows both Valve's fixes in their proton script (and their wine code) to work as well as our protonfixes.

R1kaB3rN · 2025-01-13T18:28:41Z

README.md


-* If a game is NOT on steam, but is on another platform, please try to use the ID for the platform.
+-   If a game is NOT on steam, but is on another platform, please try to use the ID for the platform.


Capitalize Steam. And I think bolding not would be better?

If a game is not on Steam, but is on another platform, please try to use the ID for the platform.

R1kaB3rN · 2025-01-13T18:29:20Z

README.md

    `umu-207350`

-* This is important in order for steam-specific game-coded fixes in proton to take effect on non-steam versions of the same game that is also shipped by steam.
+-   This is important in order for steam-specific game-coded fixes in proton to take effect on non-steam versions of the same game that is also shipped by steam.


Use Steam and Proton

This is important in order for Steam-specific game-coded fixes in Proton to take effect on non-Steam versions of the same game that is also shipped by Steam.

Also, maybe changing "Steam-specific game-coded fixes" to simply "Steam-specific fixes"?

R1kaB3rN · 2025-01-13T18:32:38Z

README.md


 4\. Determine the UMU_ID for the game, depending on its store:

-* If a game is on steam, the UMU ID will be umu-(Steam ID), even if it is from another store and also on steam.
+-   If a game is on steam, the UMU ID will be umu-(Steam ID), even if it is from another store and also on steam.


Steam instead of steam. Also, umu

If a game is on Steam, the umu ID will be umu-(Steam ID), even if it is from another storefront and also on Steam.

R1kaB3rN · 2025-01-13T18:33:41Z

README.md


 2\. Determine the STORE for the game.

 What store does the game come from? GOG? Epic (egs)? Battlenet? Amazon?

-* Available store fronts that UMU can parse are:
+-   Available store fronts that UMU can parse are:


storefronts. Also, prefer umu

Available storefronts that umu can parse are:

R1kaB3rN · 2025-01-13T18:35:47Z

README.md


 1\. Determine the TITLE of the game.

 What is the game title?

-* Game titles must be correctly capitalized as they may be used in protonfixes to display text output. all other entries should be lower case. Database search queries should be cast to lower case and/or searched case insensitive.
+-   Game titles must be correctly capitalized as they may be used in protonfixes to display text output. all other entries should be lower case. Database search queries should be cast to lower case and/or searched case insensitive.


Game titles must be correctly capitalized as they may be used in protonfixes to display text output. All other entries should be lowercase. Database search queries should be lowercased and/or searched case-insensitive.

R1kaB3rN · 2025-01-13T18:36:22Z

README.md

@@ -43,37 +45,37 @@ Get UMU_ID based on TITLE and no store:

 https://umu.openwinecomponents.org/umu_api.php?title=SOME-GAME-TITLE

-# Rules for adding umu id entries:
+## Rules for adding umu id entries:


Rules for adding umu ID entries:

R1kaB3rN · 2025-01-13T18:38:21Z

README.md


-# Current available database endpoints (results are in JSON format):
+## Current available database endpoints (results are in JSON format):


This part is a note, which preferably be not be in the title: "(results are in JSON format)".

Would probably just omit it.

R1kaB3rN · 2025-01-13T18:39:25Z

README.md


-# Online database search:
+Game launchers such as Lutris and Heroic can then query the database to match a given protonfix with games of different stores. Those launchers can provide a store name and the internal codename on that store to get the matching umu id and game title.


Capitalize id:

Game launchers such as Lutris and Heroic can then query the database to match a given protonfix with games of different stores. Those launchers can provide a store name and the internal codename on that store to get the matching umu ID and game title.

R1kaB3rN · 2025-01-13T18:40:43Z

README.md


-Information from the spreadsheet is piped into a umu sql database which is then read by various tools to fetch data.
+This repository contains the data and tools needed to provide seamless protonfixes integration for games of diffferent stores.
+Historically, Proton fixes have targeted Steam games only but umu makes it possible to use Proton for all existing Windows games.


protonfixes:

Historically, protonfixes have targeted Steam games only but umu makes it possible to use Proton for all existing Windows games.

Would probably hyperlink umu too, so:

Historically, protonfixes have targeted Steam games only but umu makes it possible to use Proton for all existing Windows games.

R1kaB3rN · 2025-01-13T18:42:46Z

README.md


-Information from the spreadsheet is piped into a umu sql database which is then read by various tools to fetch data.
+This repository contains the data and tools needed to provide seamless protonfixes integration for games of diffferent stores.


different. Also, prefer from different stores.

This repository contains the data and tools needed to provide seamless protonfixes integration for games from different stores.

Reword intro paragraph

581483d

R1kaB3rN reviewed Jan 13, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reword intro paragraph #74

Reword intro paragraph #74

strycore commented Jan 11, 2025

R1kaB3rN Jan 13, 2025 •

edited

Loading

R1kaB3rN Jan 13, 2025

R1kaB3rN Jan 13, 2025

R1kaB3rN Jan 13, 2025

R1kaB3rN Jan 13, 2025

R1kaB3rN Jan 13, 2025

R1kaB3rN Jan 13, 2025

R1kaB3rN Jan 13, 2025

R1kaB3rN Jan 13, 2025

R1kaB3rN Jan 13, 2025

R1kaB3rN Jan 13, 2025

R1kaB3rN Jan 13, 2025

R1kaB3rN Jan 13, 2025

R1kaB3rN Jan 13, 2025

R1kaB3rN Jan 13, 2025

R1kaB3rN Jan 13, 2025

R1kaB3rN Jan 13, 2025

R1kaB3rN Jan 13, 2025

R1kaB3rN Jan 13, 2025

R1kaB3rN Jan 13, 2025 •

edited

Loading

R1kaB3rN Jan 13, 2025 •

edited

Loading


		* If a game is NOT on steam, but is on another platform, please try to use the ID for the platform.
		- If a game is NOT on steam, but is on another platform, please try to use the ID for the platform.


		# Current available database endpoints (results are in JSON format):
		## Current available database endpoints (results are in JSON format):


		# Online database search:
		Game launchers such as Lutris and Heroic can then query the database to match a given protonfix with games of different stores. Those launchers can provide a store name and the internal codename on that store to get the matching umu id and game title.


		Information from the spreadsheet is piped into a umu sql database which is then read by various tools to fetch data.
		This repository contains the data and tools needed to provide seamless protonfixes integration for games of diffferent stores.

Reword intro paragraph #74

Are you sure you want to change the base?

Reword intro paragraph #74

Conversation

strycore commented Jan 11, 2025

R1kaB3rN Jan 13, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

R1kaB3rN Jan 13, 2025 • edited Loading

Choose a reason for hiding this comment

R1kaB3rN Jan 13, 2025 • edited Loading

Choose a reason for hiding this comment

R1kaB3rN Jan 13, 2025 •

edited

Loading

R1kaB3rN Jan 13, 2025 •

edited

Loading

R1kaB3rN Jan 13, 2025 •

edited

Loading