Build all dependencies for umu clients #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The Makefile currently builds python-xlib and the client is responsible for putting the module within their runtime directory. However, python-xlib depends on six.py and this will not get built for umu clients. To properly build dependencies, we need to use pip to resolve all of the dependencies and have them put in the object directory during the build process.
R1kaB3rN
force-pushed
the
umu-clients-build-deps
branch
from
c8a5ea9 to
12d9d36
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the Makefile to properly build all umu's Python dependencies for umu clients. Currently, python-xlib would be built, however the six module wouldn't which may cause Lutris users to crash due to the missing dependency.
To build all dependencies for clients like Lutris, we need to use a tool resolve all of the dependencies such as pip or uv and have them built in the Makefile.