Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes nix build issue and updates nixpkgs #144

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

beh-10257
Copy link
Contributor

@beh-10257 beh-10257 commented Jul 11, 2024

I also got ahead and make the maintainers bit the first thing in the nixos section
anyway this should fix the issue
I don't know if my commit missages are good enough or not so yeah
I tried to use fixes this time lol

also I have no idea why its Unverified so yeah

beh-10257 and others added 2 commits July 11, 2024 13:38
version = "0.1";
src = umu-launcher;
pyproject = false;
depsBuildBuild = [
pkgs.meson
Copy link
Member

@R1kaB3rN R1kaB3rN Jul 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can safely remove meson as a build dependency

Copy link
Member

@R1kaB3rN R1kaB3rN Jul 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with ninja as well, since we're no longer building reaper

@R1kaB3rN
Copy link
Member

R1kaB3rN commented Jul 11, 2024

Also, in the future, it would be nice to have the Nix package built in the CI just like the Ubuntu package.

Going to merge this for now because I want to fix that issue so Nix users can have something working. Removing of ninja and meson as a build dependency is minor and can be addressed later.

- Add new line
@R1kaB3rN R1kaB3rN merged commit 15decf6 into Open-Wine-Components:main Jul 11, 2024
6 checks passed
@beh-10257
Copy link
Contributor Author

pyproject = false;
this is needed since there is not setup.py in this project
I just checked there is no need as you said for meson and ninja
basically just remove the

  pkgs.meson
  pkgs.ninja

line
should I open another pull request ??
also
Nix package built in the CI just like the Ubuntu package.
by this you mean like a test so when a commit happen the CI can tell when the nix package breaks
is that what you mean ??

@R1kaB3rN
Copy link
Member

pyproject = false; this is needed since there is not setup.py in this project I just checked there is no need as you said for meson and ninja basically just remove the

  pkgs.meson
  pkgs.ninja

line should I open another pull request ?? also Nix package built in the CI just like the Ubuntu package. by this you mean like a test so when a commit happen the CI can tell when the nix package breaks is that what you mean ??

Yes, when you can make time, feel free to open another pull request to update the flake. And yes, that is what I mean. I think it would be very helpful and a nice-to-have if we can build the Nix package in a Github Action.

@beh-10257
Copy link
Contributor Author

yeah I will need to learn how to write github actions I guess

@R1kaB3rN R1kaB3rN mentioned this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants