-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes nix build issue and updates nixpkgs #144
Conversation
maintaining nix support and updating nixpkgs
version = "0.1"; | ||
src = umu-launcher; | ||
pyproject = false; | ||
depsBuildBuild = [ | ||
pkgs.meson |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can safely remove meson
as a build dependency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same with ninja
as well, since we're no longer building reaper
Also, in the future, it would be nice to have the Nix package built in the CI just like the Ubuntu package. Going to merge this for now because I want to fix that issue so Nix users can have something working. Removing of |
- Add new line
pyproject = false;
line |
Yes, when you can make time, feel free to open another pull request to update the flake. And yes, that is what I mean. I think it would be very helpful and a nice-to-have if we can build the Nix package in a Github Action. |
yeah I will need to learn how to write github actions I guess |
I also got ahead and make the maintainers bit the first thing in the nixos section
anyway this should fix the issue
I don't know if my commit missages are good enough or not so yeah
I tried to use fixes this time lol
also I have no idea why its
Unverified
so yeah