refactor: remove custom cleanup routine on proton install error #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Delegate cleanup routine to tempfile.TemporaryDirectory when the context manager exits
- There will be cases where the launcher will crash when setting environment variables because PROTONPATH couldn't be resolved as the move of the Proton build didn't complete.
This reverts commit a4c3f3795b50131328a0918b97b10abcaef2464a.
- Remove some assertions for the state of the compatibilitytools.d directory. Once an exception occurs, all files will automatically be cleaned up as the temporary directory is created as a context manager.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we were extracting the Proton archive directly to
$HOME/.local/share/Steam/compatibilitytools.dthen would clean that directory if the extraction was interrupted. While this process was direct, it required writing a custom cleanup routine to remove the partially extracted files in case an exception occurred. Instead, the launcher will extract to its secure temporary directory created at runtime then move the files to$HOMElike we do with the SLR. Like the previous behavior, when an exception occurs in either the download or installation, the (temporary) directory will be cleaned but by the context manager's cleanup routine. While this would be less direct as it would involve an extra step, it would result in the launcher having to remove less files from the user's home directory and make the Proton installation partially atomic.Additionally, some minor refactoring (e..g, collapsing code blocks) are done for readability.