refactor: reduce memory usage for downloads #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R1kaB3rN
force-pushed
the
lower-memory-usage
branch
from
2cdd58e to
8471599
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we're downloading and extracting the Proton and the Steam Linux Runtime archives in parallel within the tmpfs, which can utilize over 1GB+ of volatile memory in the process. Given the nature of this program and the likelihood that those resources will only become larger in the future, doing this is both unreasonable and problematic. In the worst case, this may cause the launcher to crash if the user's system does not have sufficient space at the tmpfs or root directory.
This PR changes this process so umu-launcher downloads the files in the tmpfs, but performs the decompression, extraction, and move steps within the user's home directory at
$HOME/.cache/umuwithin a temporary directory.