Added -v, --version command line option #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I can see the problem. Working on it.... |
R1kaB3rN
reviewed
Nov 13, 2024
umu/umu_run.py
Outdated
| @@ -63,6 +63,9 @@ def parse_args() -> Namespace | tuple[str, list[str]]: # noqa: D103 | |||
| ), | |||
| formatter_class=RawTextHelpFormatter, | |||
| ) | |||
| parser.add_argument("-v", "--version", action='store_true', | |||
| help="show the version and exit" | |||
There was a problem hiding this comment.
Nit: show this version and exit
This makes it consistent with the help message.
umu/umu_run.py
Outdated
| # but parse_args scans the whole command line. | ||
| # So look at the first argument and see if we have -v or --version | ||
| # in sort of the same way parse_args would. | ||
| if sys.argv[1].lower() == "-v" or sys.argv[1].lower().startswith("--v"): |
There was a problem hiding this comment.
Would reexpress as:
if sys.argv[1].endswith(("--version", "-v")):
print(
f"umu-launcher version {__version__} ({sys.version})",
file=sys.stderr,
)
sys.exit(0)
There was a problem hiding this comment.
Changes made and committed.
Many thanks.
|
Once you make some of those changes, I'll try to merge this ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds command line options -v and --version to show the umu-run version and exit.