refactor: change logging formats and move argument parsing functionality #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Debug logging will be enabled via UMU_LOG=1 instead of 3 different values.
- Causes environment variables to be printed for CLI options like -h or -v
- This lock file used to be created within top level of our runtime directory, and the launcher had been deleting each launch up until now as it made manual testing a bit easier. However, now, this shouldn't be needed anymore as the lock file is now stored within the 'var' directory
- It's not available in Python 3.10. May be refactored at a later time as we're targetting latest stable Debian for minimum versions of distribution packages, including Python. For now just use a simple class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key changes:
umu.umu_run.parse_argsto__main__.py.umu.umu_run.maintoumu.umu_run.umu_run. There will be only be onemainfunction, which is in__main__.py.UMU_LOGand soft deprecates debug in favor of simply 1.UMU_LOG=1will be the new way to enable logging. SettingUMU_LOG=debugwill still be valid and kept for compatibility until the next major version.As a result, log files should be less tedious to read through for user uploaded files or when reading through a pager utility like
less. The module's functionality is a bit more organized as well. Additionally, due to moving the argument parsing functionality, running this CLI will no longer be possible within the source directory throughumu_run.py. Therefore, for usage, either execute__main__.py, build the zipapp, Flatpak, distribution package, or create a systemd-sysext image. See https://www.freedesktop.org/software/systemd/man/latest/systemd-sysext.html.