Do not check if winetricks settings verbs are installed #306
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Umu would complain and refuse to go back and forth between settings, such as
sound=alsa
andsound=pulse
, as they were written inwinetricks.log
. This also becomes a problem when installing verbs that set a specific windows version, such asvcrun2019
which setswinxp
, as it is impossible to reset the version towin10
after the first time. Leaving it towinxp
is not an option as it can cause games to fail to launch with dx12.Initially I wanted to do this dynamically and check against the active
winetricks
version, but since the check is before the environment is set up, it would require more changes. As a result, the winetricks verbs have been dumped as a static set inumu_consts.py
to check against. Dumping script has been included for future use, and could serve as part of the dynamic check.