Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not check if winetricks settings verbs are installed #306

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

loathingKernel
Copy link
Contributor

@loathingKernel loathingKernel commented Dec 9, 2024

Umu would complain and refuse to go back and forth between settings, such as sound=alsa and sound=pulse, as they were written in winetricks.log. This also becomes a problem when installing verbs that set a specific windows version, such as vcrun2019 which sets winxp, as it is impossible to reset the version to win10 after the first time. Leaving it to winxp is not an option as it can cause games to fail to launch with dx12.

Initially I wanted to do this dynamically and check against the active winetricks version, but since the check is before the environment is set up, it would require more changes. As a result, the winetricks verbs have been dumped as a static set in umu_consts.py to check against. Dumping script has been included for future use, and could serve as part of the dynamic check.

@R1kaB3rN
Copy link
Member

R1kaB3rN commented Jan 6, 2025

To clarify, the decision to complain was implemented to prevent reentering the container, Proton’s prefix setup, and installing the same stuff twice. However, since you’re saying this is problematic and that there are cases to go back and worth, perhaps we should get rid of it all together and give clients that freedom. Or alternatively, add an environment variable to force the install

@loathingKernel
Copy link
Contributor Author

loathingKernel commented Jan 6, 2025

I think complaining is good for dlls and such, but not useful for settings. Winetricks itself will complain for dlls and require to be forced to install them again. Settings on the other hand are exempt from such checks. In that regard, winetricks is better than umu in identifying "conflicting" dlls, for example it will complain if the user tries to install vcrun2022 but vcrun2019 is already installed.

Multiple concurrent usages of winetricks is indeed an issue, but this could possibly be addressed by a mechanism that locks the prefix. Possibly as part of a mechanism to allow automatic verb fallback (waitforexitandrun -> runinprefix if something that is not winetricks runs in the prefix already)

Umu would complain and refuse to go back and forth between settings,
such as `sound=alsa` and `sound=pulse`, as they were written in
`winetricks.log`
@loathingKernel loathingKernel force-pushed the winetricks_settings_verbs branch from e4299b7 to a37f60f Compare January 6, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants